Apache OpenOffice (AOO) Bugzilla – Issue 54593
crash: drag slides bewtween 2 impress presentation, close one, save other
Last modified: 2005-11-10 13:40:43 UTC
When draging 3rd slide from backgrounds.odp presentation to another one, close the backgrounds presentation and save the other one. it crashes during saving.
Created attachment 29551 [details] backtrace
Created attachment 29552 [details] backgrounds presentation
This is reproducible. But from the behaviour this might be duplicate to i54635? The ID of the error report is rn43c8.
yes it is duplicate to issue 54593. You can verify it if you try to insert slide 3 through insert->file, it also crashes. The problems are the animated shapes on slide 3, please see my evaluation in issue 54593
Target changed.
*** Issue 54635 has been marked as a duplicate of this issue. ***
Fixed, the problem was that when inserting a slide the containing shapes got a new model. Since some of the shapes had an animation effect assigned there where living api wrapper objects for the shapes. The api wrapper object from svx already got the update that the model changed, because of fix in issue 44633. But the derived class in sd, SdXShape, still had a dangling pointer to the SdXImpressModel that was already deleted. Fixed for shapes by adding virtual callbacks to the SvxShapeMaster interface so the SvxShape can inform its master SdXShape about model changes. Since this issue was already an oversight while fixing issue 44633, I also fixed the protential problem that a reference to a slide is hold while the slide got a new model. Now SdrPage::SetModel also informs SvxDrawPage of model change. I also changed SdGenericDrawPage but since I can't make incompatibel changes now I used a trick. Before using the SdXImpressModel pointer of SdGenericDrawPage I check if the SdrModel is still the same.
@cl->wg: this was fixed in cws c03v1 but it seems I missed to register it at the cws, please verify the fix on master cov680m3 re-open issue and reassign to wg@openoffice.org
reassign to wg@openoffice.org
reset resolution to FIXED
*** Issue 55523 has been marked as a duplicate of this issue. ***
I am sorry to write this but it seems to me that the problem is not completely fixed. I am using rc3 51014 and I still cannot insert any page (or a whole file) of a presentation file into another with the "insert>file" command. The saving will invariably give you an "impossible to save" error. This was actually issue "55523: Saving impossible after inserting other file" that was marked as a duplicate of 54593, I think incorrectly: the drag and drop of slides from one open presentation file to another is now working (and that's 54593 fixed), but the use of the above menu command still does not, at least for me.
Tested in m139. Lets last mentioned problem is not reproducible in m139.
If it still occurs please writer a new issue. Closed.