Issue 48069 - sablotron version is 0.52 in tree and 1.0.2 in release
Summary: sablotron version is 0.52 in tree and 1.0.2 in release
Status: CLOSED NOT_AN_OOO_ISSUE
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 2.0 Beta
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: ab
QA Contact: issues@tools
URL:
Keywords: oooqa
: 41460 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-04-24 17:56 UTC by foskey
Modified: 2013-08-07 15:35 UTC (History)
5 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description foskey 2005-04-24 17:56:46 UTC 
Upgrade internal sablot to current release.

Since use-system-sablot works I assume that this is a trivial upgrade.  There
are a few noted bug fixes between releases.
Comment 1 Martin Hollmichel 2005-04-25 09:47:15 UTC 
reassign
Comment 2 pavel 2005-05-30 09:38:50 UTC 
abi: I do not think we can update sablotron for 2.0 or can we?
Can you please set target accordingly?
Comment 3 pavel 2005-07-08 17:01:34 UTC 
hmm, no comment for 1 month -> we probably can't make it into 2.0.

mh: you set the Target milestone to 2.0. Please consider it again.
Comment 4 pavel 2005-07-28 21:18:15 UTC 
I had a quick look at Sablot-1.0.1 and it contains *almost* all fixes that we
have in our patch file so it could even help us to clean our patch file. It
looks like the only changes needed are URL handling stuff and Export/static
handling.

Current patch file for 0.52 contains *complete* file
misc/build/Sablot-0.52/Sablot/engine/uri.cpp. Why? It only patches several lines...

mh: please decide about target. I think we can't make it into 2.0 -> 2.0.1.
Please change it if you want different target.

IIUIC it can help us to solve #i38421#.
Comment 5 andreas.bille 2005-08-16 15:52:13 UTC 
*** Issue 41460 has been marked as a duplicate of this issue. ***
Comment 6 jameslee 2005-08-17 11:14:59 UTC 
> abi->jameslee: Sablotron has indeed undergone several incompatible changes in
> previous releases. What version is your system-sablot, and why do you need to
> use it?

The why is easy.  Given that there exists a configure option
"--with-system-sablot" it should work.  Now if you tell me that it doesn't
please remove the option.

Of course the more that can be extracted from OOo the better, that includes
sablot, so please make it work.  OOo should support the latest/current sablot -
 which is 1.0.2.  If the API is not stable I'd question if sablot should be used
with OOo.
Comment 7 andreas.bille 2005-08-17 11:55:21 UTC 
abi->jameslee: As with many other options, there is no way to ensure that the
system libraries are a valied replacement for the libraries used in OO - which
does not mean that options like "--with-system-sablot" are useless. Upgrading
might solve your problem. If not, the option will nevertheless stay in place.
Comment 8 Mathias_Bauer 2005-08-22 10:50:55 UTC 
Unfortunately we couldn't deliver this for OOo2.0. 
It isn't something we should do in a micro release, so for now I change the
target back to "Later".
Comment 9 andreas.bille 2006-05-24 16:50:17 UTC 
accepted
Comment 10 andreas.bille 2007-04-04 13:29:25 UTC 
ABI->AB: As discussed ...
Comment 11 ab 2007-04-18 12:31:05 UTC 
STARTED
Comment 12 rene 2007-05-14 13:06:15 UTC 
given that m212 (cws libxslt02) removes sablotron completely, this issue is
obsolete now, is it? :)
Comment 13 rene 2007-05-14 13:07:06 UTC 
aeh, "... isn't it?"
Comment 14 caolanm 2007-05-14 13:09:43 UTC 
yeah, ditch this one. libxslt is in the 2.3 tree and sablot is removed. Wasn't
aware of this issue before now
Comment 15 rene 2007-05-14 13:14:02 UTC 
ABI/AB: I feel free to mark this as INVALID...
Comment 16 ace_dent 2008-05-17 21:50:42 UTC 
The Issue you raised has been marked as 'Resolved' and not updated within the
last 1 year+. I am therefore setting this issue to 'Verified' as the first step
towards Closing it. If you feel this is incorrect, please re-open the issue and
add any comments.

Many thanks,
Andrew
 
Cleaning-up and Closing old Issues
~ The Grand Bug Squash, pre v3 ~
http://marketing.openoffice.org/3.0/announcementbeta.html
Comment 17 ace_dent 2008-05-17 23:55:01 UTC 
As per previous posting: Verified -> Closed.
A Closed Issue is a Happy Issue (TM).

Regards,
Andrew