Issue 96896 - m37 breaks with HsqlDatabase.java:53: package helper does not exist
Summary: m37 breaks with HsqlDatabase.java:53: package helper does not exist
Status: CLOSED FIXED
Alias: None
Product: Base
Classification: Application
Component: code (show other issues)
Version: DEV300m37
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: ---
Assignee: Frank Schönheit
QA Contact: issues@dba
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-04 14:41 UTC by erack
Modified: 2009-08-13 09:28 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch fixing the issue (1.30 KB, patch)
2008-12-04 17:45 UTC, erack 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description erack 2008-12-04 14:41:14 UTC 
In m37, configure --disable-qadevooo, connectivity/qa/connectivity/tools
breaks with

./HsqlDatabase.java:53: package helper does not exist
import helper.URLHelper;
              ^
./HsqlDatabase.java:110: cannot find symbol
symbol  : variable URLHelper
location: class connectivity.tools.HsqlDatabase
        m_databaseDocumentFile = URLHelper.getFileURLFromSystemPath( documentFile );
                                 ^
Note: ./HsqlDatabase.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
2 errors
dmake:  Error code 1, while making '../../../unxlngi6/misc/ConnectivityTools_dummy.java'


This adds a dependency on module qadevOOo. Adding QADEVOOO:qadevOOo to
prj/build.lst is not sufficient, more is needed if configured
--disable-qadevooo to not attempt to build these tools.
Comment 1 rene 2008-12-04 15:06:07 UTC 
untested patch:

Index: qa/connectivity/tools/makefile.mk
===================================================================
--- qa/connectivity/tools/makefile.mk	(Revision 264849)
+++ qa/connectivity/tools/makefile.mk	(Arbeitskopie)
@@ -42,6 +42,7 @@
 	@echo "Java not available. Build skipped"
 .ELSE
 
+.IF "$(BUILD_QADEVOOO)" == "YES"
 #----- compile .java files -----------------------------------------
 
 JARFILES        = ridl.jar unoil.jar jurt.jar juh.jar java_uno.jar
OOoRunnerLight.jar
@@ -70,6 +71,8 @@
 ALL: 	ALLDEP
 .ENDIF
 
+.ENDIF
+
 .ENDIF # "$(SOLAR_JAVA)" == ""
 
 .INCLUDE :  target.mk
Index: prj/build.lst
===================================================================
--- prj/build.lst	(Revision 264849)
+++ prj/build.lst	(Arbeitskopie)
@@ -1,4 +1,4 @@
-cn  connectivity    :    comphelper MOZ:moz SO:moz_prebuilt svtools
UNIXODBC:unixODBC unoil javaunohelper HSQLDB:hsqldb NULL
+cn  connectivity    :    comphelper MOZ:moz SO:moz_prebuilt svtools
UNIXODBC:unixODBC unoil javaunohelper HSQLDB:hsqldb QADEVOOO:qadevOOo NULL
 cn  connectivity                                    usr1    -   all cn_mkout NULL
 cn  connectivity\inc                                nmake   -   all cn_inc NULL
 cn  connectivity\com\sun\star\sdbcx\comp\hsqldb     nmake   -   all
cn_jhsqldbdb cn_hsqldb cn_inc NULL
Comment 2 rene 2008-12-04 15:07:59 UTC 
please tell me where to commit this if it works
Comment 3 erack 2008-12-04 15:40:20 UTC 
I confirm the patch (once wrapped lines are joined ;-) solves the build problem.
Comment 4 rene 2008-12-04 15:40:24 UTC 
fixed as masterfix for m38
Comment 5 rene 2008-12-04 15:41:00 UTC 
actually set to FIXED...
Comment 6 Frank Schönheit 2008-12-04 16:13:54 UTC 
you were too fast for me ... actually, I also wanted to add the
  BUILD_QADEVOOO YES
line to the Common/Environment/Common section of solenv/config/sdev300.ini.

Otherwise, non-OOo builds (SO, actually :-\ ) might fail in various modules when
running the complex API tests.

Well, be it, this remaint is not a "normal" P1 build breaker anymore, and the
fix is already committed to another CWS, so ...

Thanks for your quick reaction, guys.
Comment 7 erack 2008-12-04 17:45:05 UTC 
Closely related a similar breaker in dbaccess, I'll attach a patch. Reopening
and reusing this issue here.

@rene: could you please review apply it as masterfix for m38?
Comment 8 erack 2008-12-04 17:45:44 UTC 
Created attachment 58521 [details]
patch fixing the issue
Comment 9 rene 2008-12-04 17:55:53 UTC 
yes. (and it even fixes --without-java build ;))
Comment 10 Martin Hollmichel 2009-08-13 09:28:10 UTC 
close issue