Apache OpenOffice (AOO) Bugzilla – Issue 95919
Extension Manager can't identify OOo as 3.0.1
Last modified: 2009-01-05 12:20:25 UTC
- installed OOo OOO300_m11 - tried to install oooimprovement extension which needs OOo 3.0.1 - system dependency check can't identify this OOo version as 3.0.1 - extension can't be installed
dv: Please take over.
Fixed in cws DV06 in file desktop\source\deployment\misc\dp_dependencies.cxx
Please verify. For testing you have to add the key 'OOOPackageVersion=3.0.1' to the version ini file inside the basis layer.
.
@dv: Reopened as I doubt that desktop/source/deployment/misc/dp_dependencies.cxx:1.9.156.1 is a correct fix: 1 Basis layer version ini-file buildid value (strictly speaking, the "Version" section is also missing from the string passed to expandMacros) does not contain a proper version number (it contains values like "300m11(Build:9366)"). 2 Since basis layer version ini-file buildid value is always present (and should never be empty), there is no need to alternatively read basis layer version ini-file OOOBaseVersion value. 3 Why request to add basis layer version ini-file OOOPackageVersion entry in <#desc4>? 4 Please remember to remove no-longer needed brand layer version ini-file OOOBaseVersion entry. (URE layer and basis layer version ini-file OOOBaseVersion entries have never been used in the first place, so can be removed, too.)
I suspect that this fix might replicate or - in some other way - imitate the fixes that were introduced with CWS oooimprovementcorefixes. @dv: Please consult b_michaelsen to find out whether this is true or not.
@jsk: Nothing was done on this topic on oooimprovementcorefixes. There is no active code related to this in that cws. The oooimprovement extension has a dependency in its description.xml triggering this issue, however no code from the extension or from the oooimprovementcorefixes cws is executed when this issue manifests itself.
Ok, i got that. However, is SB's assumption right that this fix is not going to work? I cannot accept an issue when a developer doubts the effectiveness of the fix.
@jsk: The CWS appears to fix the immediate problem (failure to install oooimprovement extension) by accident. That the fix is broken and causes regressions is easily seen when calling unopkg add on desktop/test/deployment/dependencies/version10000.oxt:1.2, which should fail with an unsatisfied dependency (see desktop/test/deployment/dependencies/readme.txt:1.7).
Now using OOOPackageVersion for full version info, removed old fall back code.
Please verify.
Verified. Additional actions taken: - Update e_extensions.bas to cover the minor versions as well (issue 96309) - Update specification document
Entry is in versionrc for m14
Good in m14, closing