Issue 95341 - colors of axial gradients swapped in presentation
Summary: colors of axial gradients swapped in presentation
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: viewing (show other issues)
Version: OOo 3.0
Hardware: Unknown All
: P3 Trivial (vote)
Target Milestone: OOo 3.0.1
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
: 95492 (view as issue list)
Depends on:
Blocks: 93339
  Show dependency tree
 
Reported: 2008-10-23 08:26 UTC by parity
Modified: 2008-11-26 11:51 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
The fix (707 bytes, patch)
2008-10-27 11:13 UTC, thb
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description parity 2008-10-23 08:26:00 UTC
Since Impress 3.0 there is a nasty display bug:

1. Start Impress an create an empty presentation
2. Draw a rectangle
3. Right-click on the rectangle an choose "Area".
4. Choose "Gradients".
5. Choose "Axial light red/white" from the list and click "ok".
6. Start the presentation. The Gradient seems to be inverted.

This also happens if you choose "Rectangular red/white" in step 5.

This bugs leads to the situation that my templates from OpenOffice.org 2.0 look
very unprofessional and are not usable at the moment.

Should be fixed as soon as possible (3.0.1)?
Comment 1 wolframgarten 2008-10-23 08:35:30 UTC
Reproducible. Reassigned.
Comment 2 wolframgarten 2008-10-27 09:49:12 UTC
*** Issue 95492 has been marked as a duplicate of this issue. ***
Comment 3 groucho266 2008-10-27 10:54:52 UTC
This can be fixed in fillAxialGradient() in
canvas/source/directx/dx_canvashelper_texturefill.cxx by exchanging references
to first and second color.
For the other canvas this probably can be done in a similar way.

There are three reasons for not to fix this bug for OOo 3.0.1:
1. I don't regard this bug as severe enough.  It is ugly, but it does not crash
and there is no data loss.
2. The fix may have unexpected side effects and may lead to regression.
3. There is an easy workaround.  Go to the Gradients tab in the area dialog and
exchange the colors referenced by From and To.
Comment 4 thb 2008-10-27 11:13:27 UTC
Created attachment 57498 [details]
The fix
Comment 5 thb 2008-10-27 11:15:03 UTC
Attached a fix. This is safe, corrects the problem for all platforms at once -
please strongly consider this for 3.0.1
Comment 6 parity 2008-10-27 19:17:25 UTC
If this bug is fixed in 3.1 (not in 3.0.1) it means that:

A stable version without this bug is available in March 2009.

I use OpenOffice.org for my lecture at the University. The semester ends before
OOo 3.1 will be released.

This means: I have to change all my masterslides (for every lecture) before I
present them so that they are displayed correctly. When I create the PDFs for my
students, I have to use the "old" version (without change).

I think that this bug is more severe than it looks like. It's a bug which many
people will encounter and it is a bug which produces work for the users.

Please correct it in 3.0.1 so that I can use my OOo 2.x templates.
Comment 7 thb 2008-10-28 20:59:22 UTC
@mh: this appears to be a regression (didn't have a vanilla 2.4.1 at hand, but
judging from report - @wg, could you verify?), there's a very straight-forward
fix, ok to have this 3.0.1?

@af: in case 3.0.1 is acceptable - CWS impress163?
Comment 8 groucho266 2008-10-29 10:21:00 UTC
The patch of thb is simple and straightforward and will fix this issue.  I don't
expect side effects but don't know the code well enough to be sure.

Please see my comment above why I don't see 3.0.1 as a good target though.
Comment 9 thb 2008-10-31 13:14:21 UTC
Fixed in CWS impress163.
Comment 10 thb 2008-10-31 13:14:53 UTC
.
Comment 11 groucho266 2008-10-31 13:46:26 UTC
@THB: Please explain.

I thought we had agreed *not* to change the target to 3.0.1.  I am confused (to
say it politely) by your actions.

You will find my arguments why not to do that above. And yet you make the change
without any comment?

Do you have at least the approval of the releases group?
Comment 12 wolframgarten 2008-10-31 13:56:23 UTC
thb, why do you set this on target 3.0.1 without considering QA?
Comment 13 thb 2008-10-31 16:57:22 UTC
@af: my understanding of our face2face talk yesterday was completely different.
You said you had no concerns in principle, and acknowledged the other issues
already in impress163 (and the fact that they also don't fix crashes/data losses
exclusively).

@wg: don't you read releases@ooo?

That said, I'm getting a bit annoyed by now, as I personally have no incentive
to push this for 3.0.1 - I can easily point users at ooo-build/go-oo where this
is fixed since a week already (even for 3-0 builds). So - please finally make up
your mind what to do with this issue, and have someone *with authority* accept
or deny it. I'm out here.
Comment 14 ambermoon 2008-11-02 13:14:45 UTC
For me this bug is quite an issue...

I'm using a yellow-to-white axial gradient as a background in most of my presentations.

Now i've come to this very nasty bug which shows me my gradient as an overlay of two gradients from 
transparent to the target colour (as it is normally generated), but the transparent colour is respresented 
by a fuchsia/magenta-tone colour and the magenta-part reaches over the edges of the rectangle and 
spoils the whole page.

I suppose that this issue is linked to the topic discussed here - therefore my comment.
But just changing the colours doesn't help since it will allways produce two fuchsia-to-target colour 
gradients...

BTW OOo 3.0 on Mac OS X 10.5.5

I hope it'll be fixed very soon since a lecture is on schedule :-(
Comment 15 clippka 2008-11-03 15:52:44 UTC
verified in cws, back to qa
Comment 16 wolframgarten 2008-11-07 14:31:52 UTC
Verified in CWS.
Comment 17 wolframgarten 2008-11-20 14:27:28 UTC
Tested in m12. Closed.
Comment 18 hdu@apache.org 2008-11-20 15:14:37 UTC
Adjusted the too generic subject line to prevent wrong duplicates.