Issue 93540 - "OOO_VENDOR" on Help About
Summary: "OOO_VENDOR" on Help About
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: OOO300m5
Hardware: PC Windows 2000
: P2 Trivial (vote)
Target Milestone: ---
Assignee: yuko
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks: 88888
  Show dependency tree
 
Reported: 2008-09-06 15:24 UTC by khirano
Modified: 2013-08-07 15:02 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
"OOO_VENDOR"on Help About (24.75 KB, image/jpeg)
2008-09-06 15:30 UTC, khirano
no flags Details
With zh_TW language pack, it says "OOO_VENDOR" (24.24 KB, image/jpeg)
2008-09-07 03:31 UTC, khirano
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description khirano 2008-09-06 15:24:11 UTC
"OOO_VENDOR" should be "Sun Microsystems"?
:)
Comment 1 khirano 2008-09-06 15:30:20 UTC
Created attachment 56282 [details]
"OOO_VENDOR"on Help About
Comment 2 Andrea Pescetti 2008-09-06 21:59:44 UTC
Had the same issue in the Italian version several times (query IssueZilla). It
is a localization problem, due to wrong syntax in (Japanese) translated strings.
It is language-specific.
Comment 3 khirano 2008-09-07 02:31:31 UTC
http://www.openoffice.org/issues/show_bug.cgi?id=87760

Thanks, pescetti.

yuko: Can you take a look?

Comment 4 khirano 2008-09-07 03:31:01 UTC
Created attachment 56289 [details]
With zh_TW language pack, it says "OOO_VENDOR"
Comment 5 maho.nakata 2008-09-08 01:56:42 UTC
on MacOSX PPC and Intel,
I set 
--with-vendor=\"OpenOffice.org Mac OS X porting project\"
and it works at configure stage
> checking for vendor... OpenOffice.org Mac OS X porting project
still happens on my Mac PPC.
Comment 6 yuko 2008-09-08 02:33:04 UTC
I am afraid that I do not think that this is translation issue.

   svx/source/intro/makefile.mk
        # setting the compiled by $user$ string in the About box
        OOO_VENDOR*=$(USER)$(USERNAME)
        RSCDEFS+=-DOOO_VENDOR="$(OOO_VENDOR)"

   svx/source/intro/ooo.src
        Text[ en-US ] ="Copyright 2000-2008 Sun Microsystems Inc.\nThis product
has been
        created by " OOO_VENDOR " based on OpenOffice.org.\nOpenOffice.org
acknowledges
        all community members, especially those mentioned at 
       http://www.openoffice.org/welcome/credits.html.";

I think that OOO_VENDOR is a parameter and should be replaced with an
appropriate string
at a build time, however, it does not seem to work currenctly. Is " OOO_VENDOR "
a correct syntac in the English message? In Ja and zh_TW, 「OOO_VENDOR」 is used.
If it is changed to 「 OOO_VENDOR 」, does it work?
Otherwise, please check if OOO_VENDOR is defined correctly at l10n build.
Comment 7 yuko 2008-09-08 02:48:15 UTC
I will change 「OOO_VENDOR」 in ja translation to \" OOO_VENDOR \" with Pootle.

Comment 8 Oliver Specht 2008-09-08 07:33:43 UTC
Reassigned to yuko
Comment 9 yuko 2008-09-08 07:40:41 UTC
Changed with Pootle as follows. I hope that this change will fix this issue.

=== ./svx/source/intro.po
61,62c61,63
< "Copyright 2000-2008 Sun Microsystems Inc.この製品は、OpenOffice.org "
< "を基盤として「OOO_VENDOR」が作成しました。OpenOffice.org はすべてのコミュニ
ティーメンバー、特に "
---
> "Copyright 2000-2008 Sun Microsystems Inc.\n"
> "この製品は、OpenOffice.org を基盤として \\\" OOO_VENDOR \\\" が作成しました。\n"
> "OpenOffice.org はすべてのコミュニティーメンバー、特に "

Comment 10 tora3 2008-09-08 11:59:32 UTC
@yuko: I agree with your changes.

The mystery might goes: 

A resource compiler 'rsc -DOOO_VENDOR="xxx"' will invoke its preprocessor 
'rscpp -DOOO_VENDOR="xxx"' .
rscpp is capable of recognizing a token which will be substituted. 

The existing texts 
 "Copyright 2000-2008 ... を基盤として「OOO_VENDOR」が作成しました。..."

seems to be treated as, i.e. no substitution happens, 
 "Copyright 2000-2008 ... を基盤として「OOO_VENDOR」が作成しました。..."

The keyword OOO_VENDOR seems to be unfortunately a part of string 
literal sandwiched by double quotation marks. 


The revised texts 
 "Copyright 2000-2008 ... を基盤として \\\" OOO_VENDOR \\\" が作成しました。..."

would be treated as 
 "Copyright 2000-2008 ... を基盤として " OOO_VENDOR " が作成しました。..."

So, now the keyword 'OOO_VENDOR' turns into an identifier, which would 
be expectedly substituted following the command line parameter.
 "Copyright 2000-2008 ... を基盤として " "xxx" " が作成しました。..."

And then, the series of texts would be concatenated into one text. 
 "Copyright 2000-2008 ... を基盤として xxx が作成しました。..."
Comment 11 yuko 2008-09-09 03:07:50 UTC
This is a branding issue. I got a request that this needs to be fixed in 3.0 as
a stopper bug from 
Japanese community, so I changed the priority to P2.

Also, zh_TW has the same problem, so I inform Beijin team this.


Hi Tora-san,
Thank you for the information. I understood the reason why OOO_VENDOR was not
replaced.

Comment 12 blueice7 2008-09-09 05:34:21 UTC
zh_TW has also been fixed in Pootle.
Comment 13 ivo.hinkelmann 2008-09-09 13:15:12 UTC
hi ... is it possible to replace \" just with ' ? Using ' causes usually less
problems
Comment 14 blueice7 2008-09-10 08:38:24 UTC
Fixes are delivered from Pootle.
ja http://sunvirtuallab.com:32305/sdf/20080910-rc1-fix/ ja-080910-i93540.sdf
zh-TW http://sunvirtuallab.com:32305/sdf/20080910-rc1-fix/ zh-TW-080910-i93540.sdf
Comment 15 petr.dudacek 2008-09-12 16:24:50 UTC
Verified on cws builds by Aijin and Yuko.

--> setting as verified
Comment 16 Mechtilde 2009-06-15 13:15:47 UTC
@ khirano san

Can you verify it in latest master?

Please close the Issue

Mechtilde
Comment 17 thorsten.ziehm 2009-07-20 15:59:36 UTC
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues