Ingo, can you please check what is wrong with the German language pack?

Hm, ffffthis seems to be a misunderstanding. The German spellchecker is not a
German-specific file. And our language packs only contain language specific
files, like resources, samples, templates, ....  But the German spellchecker can
be added to any product independent from its language, without adding the german
resource files, so without adding the language pack. Additionally there is no
1:1 relation between the languages of our language packs and the available
spellchecker languages. So there could be language packs with many different
spellchecker and other languages without spellchecker.

Furthermore and even more important:
You can download the language pack and you can download separately the
extension. There is no need to include extensions into language packs.

And from a technical view, I think it is not a good idea to add bundled
extensions not only to our Office products, but also to our language pack products.

-> So this works as planned and as designed.

Reassigning

Then please throw all dict files from the packages away
Because all other dict are also available as extensions

more comment after some tests

Of course they are available as extensions. But with cws native156 we introduced
a special workaround, to offer the customer a selection of spellchecker during
Office installation using bundled extensions. There is absolutely no reason to
remove this special offering again.

reopened

issue 89121 clearly suggest, what dictionary should be shipped with what
localized build.

set regression, as user of severeal localizations (e.g.) got a dictionary
installed with english installation + languagepack in 2.x 

If we really want to add bundled extensions to language packs, this is a task
for OOo 3.1 . But I do not think, that this is a good idea.  -> setting target 3.1

Now we have this problem for the 64 bit builds.

The RC 1 has only an EN_US version and for all other languages there are langpacks.

So all users which are not using EN native only find dictionary in EN, ES and FR.

So this is for me a showstopper for the 64 bit builds from Sun.

OOo installation sets can be built in any available language. There is no
technical restriction, that only English installation sets can be built.

But what is the decision of Sun to this problem.

Not all people wanting to use 64 bit builds are able to build it theirselves.

The RC1 is only built and uploaded in EN_US for 64 bit.

I have to organized the release for the Germanophone Community. So I need more
information about the decision.

This information persuades which versions we have to test and will release. 

we will also provide the other locales, but a little bit delayed because there
is just one machine available for building.

Setting target OOo 3.2.

Really setting.

it was set as Release_Blocker since 2008-07-25

Sorry, but this requires a complete new process for language pack creation and
installation. And there were other tasks with higher priority.
 

*** Issue 98793 has been marked as a duplicate of this issue. ***

As requested by andreschnabel, some comments on why it's useful to include the
dictionary in the language pack:

- Consistency: I expect en_US package + de_DE langpack to have the same features
as de_DE package + en_US langpack

- Avoid non-working UI: If you install en_US package + de_DE langpack, you get
an OpenOffice.org that looks broken. Everything is German but spell checking
simply doesn't work. 

a) The as-you-type spellcheck button can be activated and deactivated as usual
but has no effect (since the default language is set to German by the langpack
install).

b) Selecting Extras/Rechtschreibung und Grammatik has a very strange effect. It
pops up the spellcheck dialog, but the dropdown "Sprache des Wörterbuchs" is
empty. This alone is confusing but it gets worse. There's a modal popup window
asking you "Überprüfung am Anfang des Dokuments fortsetzen?", which is
nonsensical since from the user's POV the check has not even started. If you say
"Ja" you get "Die Rechtschreibprüfung ist abgeschlossen." and the whole dialog
goes away. You don't even get the chance to access the "Sprache des Wörterbuchs"
checkbox (which might give a knowledgable user a clue as to the missing dictionary).

IOW, after you install the de_DE langpack, OOo simply appears to be partially
broken to users and even very experienced OOo users (such as myself and my
collegues) can not tell what the problem is. It took us quite some time to
diagnose the lack of the German spelling dictionary in the langpack as the problem.

Of course there are possible fixes to the above usability issues, such as
greying out the as-you-type spellcheck button combined with an informative
message "You don't have a spelling dictionary installed for the currently
selected language. Spellcheck can not be performed." when selecting
"Rechtschreibung und Grammatik..." and I won't argue with you that with these
fixes in place it may be (just may) okay to leave the spelling dictionary out of
the langpack. But as long as these usability (and support) horrors exist,
putting the spellcheck dictionary back in the langpack is the proper fix.

=================
That being said, is there a simple workaround to get the dictionary built into
the langpack again? We're doing our own builds (Debian Linux) and we now face
the problem that we'd have to manually create a Debian package for the
spellcheck dictionary and to change the package lists of our LiMux Basisclient
to install it, which is an effort that we'd like to avoid. It would be much
easier if we could just get it included in the langpack .deb package again.

I created cws native224 for this task. First tests look promising.

Fixed in cws native224. If there is a dictionary available in the language of
the installation set (what is of course not always the case), then this
dictionary is added into the language pack installation set. For Linux RPMs it
is now necessary to install the language pack with

rpm -i --replacepkgs *.rpm

-- replacepkgs is required, because the dictionary package can already be
installed by the OpenOffice.org. For example the English OOo contains the French
and the Spanish dictionaries. Installation of French or Spanish language pack
would now fail without --replacepkgs. Of course every other RPM could be
installed without --replacepkgs.

@is: Could you provide a patch for 3.0.1 or replacement files that I can drop
into the 3.0.1 source tree to get this issue fixed?

Created attachment 60085 [details]
Patch for task 92147, Linux only

@mux2005: I made my changes on a 3.1 code basis, therefore I cannot provide a
patch that you can simply apply. But for Linux there are only a few changes
required. Therefore I added a zip file, that contains the changes I made in
three files:

scp2/source/ooo/file_ooo.scp
solenv/bin/modules/installer/languagepack.pm
solenv/bin/modules/installer/worker.pm

In scp2 this is only a new style for every dictionary extension. In the solenv
perl modules this are only a few lines of code. You will probably have to
integrate them manually. 
Good luck.

OF: Looks good for me in cws native224.

reassigning

can virfy it in DEV300_m47

reopened because it isn't in OOO320 RC 3

@ is: Seems that we've missed them.

No, we did not miss them. In ooo320 m8 everything still worked fine. But with
integration of cws dict32b into ooo320 m9 the German dictionary (with language
de) was splitted into de-AT, de-CH and de-DE and therefore there is no
spellchecker fitting to "de" and therefore no spellchecker is added to a "de"
language pack. 
So I will expand the process and define that "de-DE" is probably the most useful
spellchecker, that can be added into a German language pack.

@is: I've seen 3.2.0 Dutch also without writing aid package on Linux.
(Have to check windows).
Need to write a new issue?
Thanks - Cor

@cor: I just checked the OOO320 m12 Dutch language pack on Windows and Linux.
Both contain the dutch spellchecker dict_nl.oxt. So everything seems to work
fine for Dutch.

I have just downloaded and installed OOO320_m10 (3.2.0) sr and sh language packs 
on en-US full install set for Windows XP and neither of them have sr dictionary 
available.

Full install sets have sr dictionary as specified in the 
setup_native/source/packinfo/spellchecker_selection.txt but as I can read from 
Ingo the language pack is built differently and this is something being worked 
on. I would like to test m12 and later to check if Serbian is OK because both sr 
and sh language packs should have the same sr dictionary.

Mechtilde confirmed on l10n@openoffice.org that this issue was reopened and 
target set for 3.2.1.

@ is: I've just checked the .cab files of sh and sr languagepacks: No oxt files
are packed. Is this intended?

Ah, I found the error. In scp2 the file "dict-sr.oxt" does not have the flag
"FORCELANGUAGEPACK". Therefore this file is not included into the language pack
creation process, because itself is not language dependent. So only this flag
needs to be added. 
With the old assignment process to language packs, it would with the correct
flag be included into the sr language pack, but not into the sh language pack.
But with the new process for the OOo 3.2.1 it will be included in both.

@is: Thanks, great.

@ is (wrt desc#31)
I checked last night on the final release and indeed the dictionary is there.
Sorry, it must have been one of the RC's that I missed it.

IS: Fixed in cws native287.

is -> of: please verify German  and Serbian dictionaries in language packs.

OF:Looks good in cws native287

verified in OOO320_m14 -> closed