Issue 91462 - The crash about Animated image
Summary: The crash about Animated image
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: OOo 2.4.1
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-08 07:45 UTC by liujianli
Modified: 2008-08-05 20:42 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description liujianli 2008-07-08 07:45:59 UTC 
1. Start a presentation.
2. Draw a rectangle or other shapes.
3. Select the shape and then "Insert"->"Animated Image..."
4. Select "Bitmap object",push "Apply object" image button and then 
push "backwards" button,finally,adjust "duration" time.

The presentation crashed.
Comment 1 wolframgarten 2008-07-08 07:53:11 UTC 
Reproducible. Reassigned.
Comment 2 liujianli 2008-07-08 08:27:16 UTC 
I have debug it and got the reason.After pushed "backwards" button I broke at 
IMPL_LINK( AnimationWindow, ClickPlayHdl, void *, p )，the method UpdateControl 
outside while loop is given -2 as its real parameter but the parameter is 
defined as ULONG.Therefore,I assumed it led to the problem indirectly.
Comment 3 wolframgarten 2008-07-08 08:34:14 UTC 
The ID of the error report is rgqy4uc.
Comment 4 groucho266 2008-07-09 13:20:31 UTC 
Thanks liujianli, your analysis was quite right. The code in ClickPlayHdl did
not handle the backward iteration correctly.

Fixed by making sure that the index does not become negative.

Modified file:
sd/source/ui/dlg/animobj.cxx    rev. 1.28.74.1
Comment 5 groucho266 2008-07-18 12:28:16 UTC 
Please verify.
Comment 6 wolframgarten 2008-07-18 13:09:08 UTC 
Verified in CWS.
Comment 7 maand 2008-08-05 13:40:44 UTC 
Verified with OOo-Dev m28 on OpenSuSE 10.3, KDE 3.5.9, ATI Radeon mobility 
9700. It works without a crash.
Comment 8 maand 2008-08-05 20:42:30 UTC 
Verified on WinXP with OOo3 m28. It works.
Closing.