Apache OpenOffice (AOO) Bugzilla – Issue 91071
Better Polish AutoCorrect File
Last modified: 2013-08-07 15:02:18 UTC
I attach a new version that corrects some problems with the current autocorrect file (there were some duplicates & one entry was a false alarm). I file it as enhancement but because there is a little error in the previous autocorrect, it also fixes a defect, that's why I'd like to ask to integrate it into 3.0. Thanks.
Created attachment 54741 [details] New autocorrect file
assigning to va
VA: New autocorrection file will be integrated in OOo 3.0.1.
Set target to OOo 3.1.
@milek: Could you please provide me 2 or 3 example entries, which you modified, so we can verify the fix/enhancement. Thanks in advance.
@vl: good that you asked, I've seen another mistake there ("za granicą" should not be changed). Attaching a new version. Test it on "maja" (deleted, was changed to "mają" before), "aż nad to" -> "aż nadto" (added), "chba" -> "chyba" (added).
Created attachment 57944 [details] Corrected autocorrect file
@milek: Could you please recheck your updated AutoCorrection-List? I get only 7 entries: --, -->, ->, ..., (c), (r) and (tm). But the file size seems to be okay: 7,63 KB (new), 7,64 KB (old).
va: you're right, I didn't notice I needed entities conversion. This time I checked it twice, attaching a still newer version...
Created attachment 58347 [details] Corrected autocorrect file (2nd ver)
AutoCorrection List looks good now. Checked in. - Thanks, Milek.
@sba: Please verify.
Verified in CWS extras310.
It seems that in 3.2 RC1 it got replaced by some ancient and useless version of the file. Could you please check what happened?
SBA->OS: In the Tools - AutoCorrect Options dialog, the Polish AutoCorrect Replacement list is empty in OOO320_m9. - The file I can find in /share/autocorr/ has a size of 8 kB and after un-zipping it, it shows a lot of entries and looks good at first glance. So the file is in the installation. - When I changed something (add or remove an entry), this file should be copied to /user/autocorr/ and get modified accordingly. This does not take place. - Manually copying the file to /user/autocorr/ still shows an empty list. - Created a new replacement pair for Polish, closed and reopened the dialog and the list is empty again. I tried other languages, too. As far as I can see, only PL is affected. This can not be a general encoding problem because Russian and Farsi lists work well.
@sba, va: I found the reason. The internal directory "META-INF" was "Meta-inf" in the Polish file. While it worked in the past, starting from 3.2, only META-INF works. I changed this and voila, everything works fine. The attached version is the correct file. As this is a trivial change of a directory name and the issue is annoying, I would ask to accept this change for 3.2.1 (I already adjusted the summary). Thanks!
Created attachment 68503 [details] Corrected autocorrect file (META-INF bug)
reassigned to va
.
Started.
Fixed in CWS SDK321. @sba to verify this patch just unzip the AutoCorr file located here: InstallationPath/.../Basis/share/ autocorr/acor_pl-PL.dat - There must be a directory called "META-INF" instead of "Meta-inf".
@sba: Please verify when CWS is ready for QA.
I've just checked all acor*.dat in OOO320m17 (3.2.1rc1) Linux X64 en-US: 1) some of them have both META-INF/manifest.xml and Meta-inf/manifest.xml with redundant informations. For example in acor_da-DK: in META-INF/manifest.xml: <manifest:file-entry manifest:media-type="" manifest:full-path="Meta-inf/manifest.xml"/> and furthermore: <manifest:file-entry manifest:media-type="" manifest:full-path="Meta-inf/"/> <manifest:file-entry manifest:media-type="" manifest:full-path="META-INF/"/> L10n affected: - af-ZA - da-DK - en-ZA - af-ZA 2) Another language is broken in 3.2 like PL: mn-MN (mongolian) Should it be submitted as new issues?
Issue reopened.
Adding some CCs. SBA->VA: Please proceed. Reassigned to VA.
Okay, these files will be fixed, too: - af-ZA - da-DK - en-ZA - mn-MN
Fixed.
Created attachment 69514 [details] af-ZA
Created attachment 69515 [details] da-DK
Created attachment 69516 [details] en-ZA
Created attachment 69517 [details] mn-MN
Created attachment 69518 [details] en-ZA (now with correct MIME type)
@sba: [Again ;-)] Please verify. AutoCorr files are attached.
Note: With the wrong MIME stuff cases, newly enterd AutoCorr entries for the respective languages (i.e. replace aa with aaa) vansihed after the dialog was closed and reopened. Now pl-PL, af-ZA, da-DK, en-ZA and mn-MN work well. Verified in CWS sdk321.
OK in OOO320_m18. Closed.