Issue 89468 - to-be-DEV300_m13 breaks now - SYSTEM_HYPH still builds and delivers internal hyphen
Summary: to-be-DEV300_m13 breaks now - SYSTEM_HYPH still builds and delivers internal ...
Status: CLOSED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: DEV300m12
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: OOo 3.0
Assignee: gregor.hartmann
QA Contact: Unknown
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-14 15:01 UTC by rene
Modified: 2008-06-23 15:41 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch (1.39 KB, patch)
2008-05-14 15:10 UTC, rene 		no flags Details | Diff
deliverinh hyphen.h for windows too (440 bytes, patch)
2008-05-17 15:45 UTC, gregor.hartmann 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description rene 2008-05-14 15:01:03 UTC 
Hi,

I just saw that SYSTEM_HYPH still builds and delivers internal hyphen and
therefore the internal hyphen.h and libhyphen.a get used. Additionally the
module is built when we don't need hyph_en_US.dic at all.

The following patch fixes this.

vg: Masterfix?
Comment 1 rene 2008-05-14 15:10:53 UTC 
Created attachment 53626 [details]
patch
Comment 2 vg 2008-05-15 10:37:26 UTC 
@rene: the makefile.mk fix is committed for m13, the d.lst has already the line:
..\%__SRC%\misc\build\hyphen-2.3.1\hyphen.h %_DEST%\inc%_EXT%\hyphen.h
=> your changes skipped
Comment 3 rene 2008-05-15 10:44:47 UTC 
vg: err, no....

the point of the d.lst change is that the file needs to get delivered *FROM* the
inc directory and not at all in system-hyph case.

The change you see changes where it gets delivered *TO*
Comment 4 vg 2008-05-15 11:53:10 UTC 
@rene: ok, I committed the r1.6... Please verify
Comment 5 gregor.hartmann 2008-05-17 15:41:56 UTC 
the windows version now breaks
patch will follow in a second
Comment 6 gregor.hartmann 2008-05-17 15:45:40 UTC 
Created attachment 53740 [details]
deliverinh hyphen.h for windows too
Comment 7 gregor.hartmann 2008-05-17 15:50:05 UTC 
assigning to vg as he is in charge anyways
Comment 8 pavel 2008-05-17 21:15:16 UTC 
yes, gh's change is still needed for Windows...
Comment 9 gregor.hartmann 2008-05-18 20:47:40 UTC 
vg masterfix on m13 !?
Comment 10 vg 2008-05-19 09:19:07 UTC 
@gh: last patch commited as master fix for m14. Please verify
Comment 11 vg 2008-05-19 09:34:16 UTC 
reassign for verification
Comment 12 pavel 2008-05-22 19:11:10 UTC 
Verified in m14. Closing.
Comment 13 thorsten.ziehm 2008-06-23 15:41:44 UTC 
This Master-Fix is integrated in OOo 3.0 code line, therefore I change the
target of this issue to the corresponding target.