Issue 87016 - to-be-DEV300_m3: svx/source/table/tablemodel.cxx
Summary: to-be-DEV300_m3: svx/source/table/tablemodel.cxx
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: DEV300m1
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: ---
Assignee: clippka
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-13 22:26 UTC by pavel
Modified: 2008-04-29 11:48 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
excerpt from #dev.openoffice.org IRC talk concerning this issue (4.20 KB, text/plain)
2008-03-14 10:20 UTC, rt 		no flags Details
Possible patch to fix this issue (1.38 KB, text/plain)
2008-03-14 11:16 UTC, clippka 		no flags Details
patch to fix the second break (479 bytes, text/plain)
2008-03-14 12:03 UTC, clippka 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2008-03-13 22:26:39 UTC 
/home/oo/BuildDir/ooo_DEV300_m3_src/svx/source/table/tablemodel.cxx 
/home/oo/BuildDir/ooo_DEV300_m3_src/solver/300/unxlngx6.pro/inc/stl/stl/_vector.h: In member 
function 'void _STL::vector<_Tp, _Alloc>::_M_insert_dispatch(_Tp*, _Integer, _Integer, const 
_STL::__true_type&) [with _Integer = int, _Tp = rtl::Reference<sdr::table::TableRow>, _Alloc = 
_STL::allocator<rtl::Reference<sdr::table::TableRow> >]':
/home/oo/BuildDir/ooo_DEV300_m3_src/solver/300/unxlngx6.pro/inc/stl/stl/_vector.h:388:   
instantiated from 'void _STL::vector<_Tp, _Alloc>::insert(_Tp*, _InputIterator, _InputIterator) [with 
_InputIterator = int, _Tp = rtl::Reference<sdr::table::TableRow>, _Alloc = 
_STL::allocator<rtl::Reference<sdr::table::TableRow> >]'
/home/oo/BuildDir/ooo_DEV300_m3_src/svx/source/table/tablemodel.cxx:128:   instantiated from 
'sal_Int32 sdr::table::insert_range(Vec&, sal_Int32, sal_Int32) [with Vec = 
_STL::vector<rtl::Reference<sdr::table::TableRow>, 
_STL::allocator<rtl::Reference<sdr::table::TableRow> > >, Iter = rtl::Reference<sdr::table::TableRow>*]'
/home/oo/BuildDir/ooo_DEV300_m3_src/svx/source/table/tablemodel.cxx:265:   instantiated from 
here
/home/oo/BuildDir/ooo_DEV300_m3_src/solver/300/unxlngx6.pro/inc/stl/stl/_vector.h:374: error: 
invalid conversion from 'int' to 'sdr::table::TableRow*'
/home/oo/BuildDir/ooo_DEV300_m3_src/solver/300/unxlngx6.pro/inc/stl/stl/_vector.h:374: error:   
initializing argument 1 of 'rtl::Reference<reference_type>::Reference(reference_type*) [with 
reference_type = sdr::table::TableRow]'
/home/oo/BuildDir/ooo_DEV300_m3_src/solver/300/unxlngx6.pro/inc/stl/stl/_vector.h: In member 
function 'void _STL::vector<_Tp, _Alloc>::_M_insert_dispatch(_Tp*, _Integer, _Integer, const 
_STL::__true_type&) [with _Integer = int, _Tp = rtl::Reference<sdr::table::TableColumn>, _Alloc = 
_STL::allocator<rtl::Reference<sdr::table::TableColumn> >]':
/home/oo/BuildDir/ooo_DEV300_m3_src/solver/300/unxlngx6.pro/inc/stl/stl/_vector.h:388:   
instantiated from 'void _STL::vector<_Tp, _Alloc>::insert(_Tp*, _InputIterator, _InputIterator) [with 
_InputIterator = int, _Tp = rtl::Reference<sdr::table::TableColumn>, _Alloc = 
_STL::allocator<rtl::Reference<sdr::table::TableColumn> >]'
/home/oo/BuildDir/ooo_DEV300_m3_src/svx/source/table/tablemodel.cxx:128:   instantiated from 
'sal_Int32 sdr::table::insert_range(Vec&, sal_Int32, sal_Int32) [with Vec = 
_STL::vector<rtl::Reference<sdr::table::TableColumn>, 
_STL::allocator<rtl::Reference<sdr::table::TableColumn> > >, Iter = 
rtl::Reference<sdr::table::TableColumn>*]'
/home/oo/BuildDir/ooo_DEV300_m3_src/svx/source/table/tablemodel.cxx:298:   instantiated from 
here
/home/oo/BuildDir/ooo_DEV300_m3_src/solver/300/unxlngx6.pro/inc/stl/stl/_vector.h:374: error: 
invalid conversion from 'int' to 'sdr::table::TableColumn*'
/home/oo/BuildDir/ooo_DEV300_m3_src/solver/300/unxlngx6.pro/inc/stl/stl/_vector.h:374: error:   
initializing argument 1 of 'rtl::Reference<reference_type>::Reference(reference_type*) [with 
reference_type = sdr::table::TableColumn]'
dmake:  Error code 1, while making '../../unxlngx6.pro/slo/tablemodel.obj'

ERROR: Error 65280 occurred while making /home/oo/BuildDir/ooo_DEV300_m3_src/svx/source/table
Comment 1 rt 2008-03-14 09:08:54 UTC 
Christian,

Any idea how to fix this?
Comment 2 rt 2008-03-14 10:14:23 UTC 
I'm afraid I do not get this done as masterfix for m3, therefore reassinging to
code owner.
Comment 3 rt 2008-03-14 10:20:32 UTC 
Created attachment 52094 [details]
excerpt from #dev.openoffice.org IRC talk concerning this issue
Comment 4 clippka 2008-03-14 10:38:43 UTC 
I try to think of a patch, but I don't have this plattform to build so I would
need further assistance
Comment 5 clippka 2008-03-14 11:16:55 UTC 
Created attachment 52097 [details]
Possible patch to fix this issue
Comment 6 pavel 2008-03-14 11:36:34 UTC 
Compiles without problems.

But the next file:

/home/oo/BuildDir/ooo_DEV300_m3_src/svx/source/table/tablehandles.cxx: In member function 
'sal_Int32 sdr::table::TableEdgeHdl::GetValidDragOffset(const SdrDragStat&) const':
/home/oo/BuildDir/ooo_DEV300_m3_src/svx/source/table/tablehandles.cxx:137: error: no matching 
function for call to 'max(long int, const sal_Int32&)'
dmake:  Error code 1, while making '../../unxlngx6.pro/slo/tablehandles.obj'

ERROR: Error 65280 occurred while making /home/oo/BuildDir/ooo_DEV300_m3_src/svx/source/table
oo@octopus:~/BuildDir/ooo_DEV300_m3_src/svx/source/table>
Comment 7 clippka 2008-03-14 12:03:31 UTC 
Created attachment 52099 [details]
patch to fix the second break
Comment 8 pavel 2008-03-14 12:08:28 UTC 
The line should read:

        return std::min( std::max( static_cast<sal_Int32>(mbHorizontal ? rDrag.GetDY() : rDrag.GetDX()), 
mnMin ), mnMax );
Comment 9 rt 2008-03-14 12:34:56 UTC 
Both fixes committed as masterfix for DEV300 m3.
Comment 10 Martin Hollmichel 2008-04-29 11:48:18 UTC 
close issue.