Apache OpenOffice (AOO) Bugzilla – Issue 82689
editing a used list styles is not covered by the undo function
Last modified: 2013-08-07 14:42:49 UTC
Hi, please ... - open the attached odt - open the "Styles and Formatting" window (if not already open) - switch to "List Styles" - right-click "Numbering 1" "Modify..." - change anything here, for example apply a bullet: The save button has been enabled as expected, but undo is disabled.
Created attachment 48953 [details] issue_82689.odt (document to reproduce the bug)
(Found on SO8 PU8 Linux and OOo 2.3 Windows.)
MRU->AMA: problem is, when a list style has already been applied somewhere in the document. Then a change in that style won't be undoable anymore. works fine if the style has not been used...
Created attachment 49756 [details] patchfile
liuyu->ama: I find a way to solve this problem, but I'm not sure if it will bring other problems. Please have a look at the patch.
ama->liuyu: To be honest, I do not know if this change causes side effects. First I get an violated assertion from the SwUndoInsNum object but I do not know at the moment if this is really a problem. I will talk to my colleagues and have a deeper look into the code. Stay tuned!
ama->liuyu: Great! I thought we would need a new SwUndo class and a lot of coding but you found the right place to fix this issue with a cool small patch! The piece of code you changed has been checked in 10 years ago when Writer wasn't able to undo any style changes. I do not see any problems nor side effects of your patch, it will be integrated into CWS sw8u10bf02.
Fixed in CWS sw8u10bf02 docnum.cxx unnum.cxx
Ready for QA
Verified in CWS sw8u10bf02 Note: follow up issue 84546 because the string in the Undo menu is wrong.
This issue is closed automatically and wasn't rechecked in a current version of OOo. The fixed issue should be integrated in OOo since more than half a year. If you think this issue isn't fixed in a current version (OOo 3.1), please reopen it and change the field 'Target Milestone' accordingly. If you want to download a current version of OOo => http://download.openoffice.org/index.html If you want to know more about the handling of fixed/verified issues => http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues