Issue 82085 - SRC680_m231: ft2build.h not included thus freetype is not happy...
Summary: SRC680_m231: ft2build.h not included thus freetype is not happy...
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: 680m230
Hardware: All Unix, all
: P1 (highest) Trivial (vote)
Target Milestone: next build
Assignee: hdu@apache.org
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-29 08:21 UTC by pavel
Modified: 2007-10-05 16:02 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2007-09-29 08:21:49 UTC 
Hi,

when building on SL9.0 based build machine with fontconfig 2.2.1 and freetype from the OOo CVS, I 
got this:

In file included from /usr/include/fontconfig/fcfreetype.h:27,
                 from /disk2/pavel/BuildDir/ooo_SRC680_m231_src/psprint/source/fontmanager/
fontconfig.cxx:41:
/disk2/pavel/BuildDir/ooo_SRC680_m231_src/solver/680/unxlngi6.pro/inc/freetype/freetype.h:20:2: 
#error "`ft2build.h' hasn't been included yet!"
/disk2/pavel/BuildDir/ooo_SRC680_m231_src/solver/680/unxlngi6.pro/inc/freetype/freetype.h:21:2: 
#error "Please always use macros to include FreeType header files."
/disk2/pavel/BuildDir/ooo_SRC680_m231_src/solver/680/unxlngi6.pro/inc/freetype/freetype.h:22:2: 
#error "Example:"
/disk2/pavel/BuildDir/ooo_SRC680_m231_src/solver/680/unxlngi6.pro/inc/freetype/freetype.h:23:2: 
#error "  #include <ft2build.h>"
/disk2/pavel/BuildDir/ooo_SRC680_m231_src/solver/680/unxlngi6.pro/inc/freetype/freetype.h:24:2: 
#error "  #include FT_FREETYPE_H"

The simplest workaround is this:

pavel@oo:~/BuildDir/ooo_SRC680_m231_src/psprint/source/fontmanager> diff -u fontconfig.cxx.orig 
fontconfig.cxx
--- fontconfig.cxx.orig 2007-09-29 10:34:25.000000000 +0200
+++ fontconfig.cxx      2007-09-29 10:33:50.000000000 +0200
@@ -38,6 +38,7 @@
 
 #ifdef ENABLE_FONTCONFIG
 #include <fontconfig/fontconfig.h>
+#include <ft2build.h>
 #include <fontconfig/fcfreetype.h>
 // be compatible with fontconfig 2.2.0 release
 #ifndef FC_WEIGHT_BOOK
pavel@oo:~/BuildDir/ooo_SRC680_m231_src/psprint/source/fontmanager>
Comment 1 philipp.lohmann 2007-10-01 07:58:26 UTC 
pl->hdu: hr solved this by including ft2build.h in our version of fcfreetype.h;
maybe the attached solution is better ?
Comment 2 hdu@apache.org 2007-10-01 09:08:17 UTC 
Applied the patch for next master workspace (SRC680_m232).
@pjanik: thanks for the patch!
Comment 3 jens-heiner.rechtien 2007-10-01 09:31:50 UTC 
Certainly the attached version is better ... our quick master fix didn't
consider cases with system supplied fontconfig libraries.
Comment 4 hdu@apache.org 2007-10-04 10:09:26 UTC 
@pjanik: please mark this issue as "verified" if ok
Comment 5 hdu@apache.org 2007-10-04 10:12:46 UTC 
@pjanik: please mark this issue as verified if ok
Comment 6 pavel 2007-10-05 16:02:09 UTC 
Verified, closing.