Issue 81123 - xmlhelp: signed/unsigned stuff for ppc
Summary: xmlhelp: signed/unsigned stuff for ppc
Status: CLOSED DUPLICATE of issue 83413
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: 680m226
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: ab
QA Contact: Unknown
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-29 14:37 UTC by pmladek
Modified: 2008-07-24 13:46 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Proposed fix. (398 bytes, patch)
2007-08-29 14:38 UTC, pmladek 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pmladek 2007-08-29 14:37:30 UTC 
The number variables (char, integer, ...) are unsigned by default on ppc. OOo
code is not clean, so it is temporary compiled with -fsigned-char.

I will attach a patch that fixes the signed/unsigned stuff in the module xmlhelp.

Note: It fixes the new warnings: "comparison is always true/false" that appeared
after one compiled the code without -fsigned-char.
Comment 1 pmladek 2007-08-29 14:38:07 UTC 
Created attachment 47845 [details]
Proposed fix.
Comment 2 Mathias_Bauer 2007-09-01 16:55:37 UTC 
xmlhelp now is owned by ab
Comment 3 ab 2007-09-11 07:10:09 UTC 
STARTED, 2.4
Comment 4 ab 2007-10-02 11:02:13 UTC 
Still planned for 2.4, evaluation pending
Comment 5 ab 2007-11-14 14:00:01 UTC 
Added to cws ab42
Comment 6 ab 2007-12-21 14:02:33 UTC 
ab->pmladek: This problem seems to be already fixed in the scope
of #i83413. Please have a look at helplinker.cxx r1.10 and check if
the fix is ok for you. Set to duplicate for now and remove from cws.


*** This issue has been marked as a duplicate of 83413 ***
Comment 7 caolanm 2008-07-24 13:46:23 UTC 
closing