Issue 72336 - to-be-SRC680_m196: cast from 'SfxItemSet*' to 'sal_Int32' loses precision
Summary: to-be-SRC680_m196: cast from 'SfxItemSet*' to 'sal_Int32' loses precision
Status: CLOSED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: 680m193
Hardware: PC (x86_64) Linux, all
: P1 (highest) Trivial (vote)
Target Milestone: OOo 2.2
Assignee: caolanm
QA Contact: Unknown
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-06 21:57 UTC by pavel
Modified: 2006-12-18 15:29 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for review (686 bytes, patch)
2006-12-10 20:02 UTC, pavel 		no flags Details | Diff
Patch for review (686 bytes, patch)
2006-12-10 20:02 UTC, pavel 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2006-12-06 21:57:31 UTC 
Hi,

to-be-m196 breaks on 64bit platforms with:

data/oo/BuildDir/ooo_SRC680_m196_src/svtools/source/items1/stylepool.cxx: In static member 
function 'static rtl::OUString StylePool::nameOf(boost::shared_ptr<SfxItemSet>)':
/data/oo/BuildDir/ooo_SRC680_m196_src/svtools/source/items1/stylepool.cxx:190: error: cast from 
'SfxItemSet*' to 'sal_Int32' loses precision
dmake:  Error code 1, while making '../../unxlngx6.pro/slo/stylepool.obj'
'---* tg_merge.mk *---'

ERROR: Error 65280 occurred while making /data/oo/BuildDir/ooo_SRC680_m196_src/svtools/source/
items1
Comment 1 pavel 2006-12-10 20:01:02 UTC 
please review attached patch.
Comment 2 pavel 2006-12-10 20:02:17 UTC 
Created attachment 41305 [details]
Patch for review
Comment 3 pavel 2006-12-10 20:02:55 UTC 
Created attachment 41306 [details]
Patch for review
Comment 4 andreas.martens 2006-12-11 07:47:20 UTC 
Yes, the patch is okay.
sal_uIntPtr instead of sal_IntPtr could be an option even I don't think we will
get "negative" values there, so I'm fine with the patch.
Comment 5 pavel 2006-12-11 08:10:11 UTC 
Patch applied to pji72336.

Caolan, can you please verify?
Comment 6 pavel 2006-12-11 08:10:24 UTC 
.
Comment 7 caolanm 2006-12-11 08:55:09 UTC 
verified
Comment 8 caolanm 2006-12-18 15:29:48 UTC 
closing, m197