Apache OpenOffice (AOO) Bugzilla – Issue 72275
Undo suggest obsolete action when adding row in table using "Tab" key
Last modified: 2013-08-07 14:38:26 UTC
In Wrtiter Undo suggest wrong action when extending table by entering numeric data and Tabbing into next row. Steps to reproduce: 1. Start Writer and insert table (either via menu Table\Insert\Table or from the toolbar). Default table size is fine. 2. Start entering random numeric data in each cell. Type some single digit in the last cell (see attached "step1.gif"). 3. Press Tab to extend the table and go into first cell of new row. Now try to undo row insertion - go to Edit and there is no "Undo: Insert row" (which you would expect). Instead you see "Undo: format cell" (on attached "step2.gif" see new row circled in green and wrong undo circled in red). If I extend table without entering any data or enter non-numeric string undo correctly offers "Undo: Insert row".
Created attachment 41131 [details] screenshot of step 2
Created attachment 41132 [details] Screenshot of step 3
MRU->HBRINKM: when the "number recognition" in tables is not active (which is the case by default) I do not think that it is necessary to perfor TWO undo steps ("Format Cell" and "Add row") for adding a row at the end of a table.
Created attachment 42650 [details] Details Of tests
The above test of Open Office 2.1 (EN version) were done on using the Microsoft Windows XP Professional Version 2002 Service Pack 2 Operating system, on a Intel ® Pentium® 4 CPU 1.80GHz 1.82Hz, 512 MB of RAM.
The issue can be replicated in OO v2.1 running on Win XP SP1 and OO v2.0.2 running on Fedora 5 kernel 2.6.17. An odd behaviour was found when replicating the issue. If I click out of the cell and click back in to the cell and inserted a row with a tab, one undo action properly undo the inserted row. Also, if the last cell contained alphanumeric data and a new row is inserted, the action is properly undone when you click on undo, but the cursor reverts back to the top of the document instead of the previous cell. However, performing two undo when a numeric data is in the last cell, brings the cursor back to the proper cell.
A few observations: I. Auto-Formatting (with numbers): When you type a number in a cell, the cell is formatted automatically if you hit the Tab key. Examples of input with number formatting: -1, 5%, $4, 333, +33 II. Auto-Formatting (with letters): If you type a lower-case letter as the first character in a cell and hit the Tab key, the lower-case letter will be converted into upper-case letter III Undo ordering: (with numbers)If you follow kpalagin's steps carefully with numbers as input, you will notice that once the first undo is executed, it will undo the formatting of the number first followed by removing the new row on the second undo. Take note of the ordering of the undo's. Undo ordering: (with letters) Instead of a number input, type a lower-case letter (eg. "d"), then hit the Tab key. Notice that the first undo removes the new row created and the second undo will undo the formatting of the lower-case letter (eg. "D" back to "d") IV Observation: When the Tab key is hit, a new row is created first then the current cell containing the number is auto-formatted. That's why undo formatting is undone first before the removal of the new row.
The tests were done under Windows XP sp2 and OOo version 2.1
ama took over undo
Any chance to target this for 3.x?