Issue 71248 - Office (CWS) crashes when pasting html content into Writer document
Summary: Office (CWS) crashes when pasting html content into Writer document
Status: CLOSED FIXED
Alias: None
Product: *Testproduct
Classification: Test
Component: code (show other issues)
Version: current
Hardware: All Windows XP
: P2 Trivial (vote)
Target Milestone: OOo 2.2
Assignee: stefan.baltzer
QA Contact: issues@test
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-06 11:57 UTC by stefan.baltzer
Modified: 2006-11-27 11:41 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description stefan.baltzer 2006-11-06 11:57:12 UTC 
- Open Browser (I used Firefox 2.0)
 - URL: www.openoffice.org
 - select all
 - copy
 - Open Writer documenrt in CWS aw024
 - paste
-> crash

Note: did not occur on m185 Master build.
Comment 1 Armin Le Grand 2006-11-06 12:46:51 UTC 
AW: Problem already identified: FS changed SdrUnoObj::GetUnoControl() to only
return an awt::XControl when one is visualized (using
ViewContactOfUnoControl::getUnoControlForDevice()). In SW (htmlform.cxx)
GetUnoControl() is used and the result is not tested. The next access then
stumbles over an invalid reference -> GPF.
Looks like GetUnoControl() returned a control always in the past. If this is
necessary i do not know. Need to ask FS for that who is not here this week
(unfortunately).
BTW: There are more spaces in OOo where GetUnoControl() is used, most of them
secured with testing the return value before usage.
Comment 2 Armin Le Grand 2006-11-06 14:07:27 UTC 
AW: Took a look at the old behaviour. There, a PageView already exists and the
xControl is found. Nonetheless the SW code needs to be secured.
A PageView will exist in new code too, but there is no VOC created since it's
not painted yet. A VOC may be forced when the PageView exists, but how finf the
PageView using the given OutputDevice?
Comment 3 Armin Le Grand 2006-11-06 14:36:03 UTC 
AW: Made a secure fix in htmlform.cxx to secure usage of GetUnoControl() result.
Writing a follow-up task for FS to clarify intended behaviour.
AW: Tested, checked in. Building installsets.
Comment 4 Armin Le Grand 2006-11-06 15:21:35 UTC 
AW: Submitted #i71260# to FS explaining problem and pointing back to this task.
Solved.
Comment 5 Armin Le Grand 2006-11-07 10:02:32 UTC 
AW: Verified using the wntmsci10.pro version. SBA already looked at the
'linux'-version, i do not know if pro or non-pro.
AW->SBA: Please verify, all install-sets are there.
Comment 6 stefan.baltzer 2006-11-07 10:46:20 UTC 
SBA: Verified in CWS aw024.
Comment 7 stefan.baltzer 2006-11-27 11:41:08 UTC 
SBA: OK in OOE680m5 Build 9093.
Closed.