Issue 6853 - Openoffice crashes when using Data Source Administration.
Summary: Openoffice crashes when using Data Source Administration.
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: PC Other OS
: P3 Trivial (vote)
Target Milestone: OOo 1.1 Beta
Assignee: marc.neumann
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-08 15:43 UTC by Unknown
Modified: 2003-02-20 11:08 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2002-08-08 15:43:56 UTC
Error Message
=============

The instruction at "0x00402f86" referenced memory at "0x0061018a". the memory 
could not be read.

An exception 'Unhandled Win32 Exception' has occurred in soffice.exe. 

Also

'An unrecoverable error has occurred.  All modified files have been saved and 
can probably be recovered at program restart'. Then it gives the above error 
(see notes further down).

Environment
===========

PC
Windows NT4 Service Pack 6
OpenOffice 1.0.1

Symptoms
========

Produces the above error and closes down the app (even the quickstarter).

How to reproduce.
=================

Start up Writer.

Click the data sources button.

Right click on Bibliography and select 'Administrate Data Sources'.

Click on the empty document then click the data sources button to remove the 
Data Sources window.  This leaves the Data Source Administration window open. I 
tried to close the Data Sources window by clicking on the Data Sources button 
but this did not close it.  I found if I clicked on the document the the button 
the Data Sources window closed.

Click on the Data Sources Administration window (I moved it round a bit).  I am 
not sure if this is necessary but I did it when the error was produced.

Open up a new Writer document. 

Click on the Data Source Administration window or move it a bit.

Bingo - The error is produced.

Also instead of opening up a new Writer document just go and play around with 
the Data Source Administration window tabs etc.  This will produce a 'An 
unrecoverable error has occurred'.

Thoughts
========

It looks like the Data Source Administration window is Modal as other buttons 
seem to be non functioning.  This makes sense.  However by clicking on the 
document it seems to lose its modal status and the buttons on the toolbar 
workwork (e.g. Graphics on/off).
 
I can duplicate this every time.
Comment 1 Frank Schönheit 2002-08-09 07:53:04 UTC
could reproduce
To me, the problem seems to be the clickable button in the toolbox
Comment 2 Frank Schönheit 2002-08-09 07:54:12 UTC
argh. Have to submit a bug for issuezilla I think. checking "reassign"
and "confirm" does neither confirm nor reassign, if the owner is not
changed
Comment 3 Frank Schönheit 2002-08-09 07:55:55 UTC
hmm. this time it worked, so it's only me :)

Anyway, assigning this to the VCL guys. I know they had problems with
this effect (clickable toolboxes when a modal dialog is open), and
this is fixed in the latest internal builds.

Stephan, perhaps you should consider this fix for 1.0.2 ....
Comment 4 Frank Schönheit 2002-08-09 07:57:14 UTC
forgot to change the component/QA contact, and this time the real new
owner (hopefully)
Comment 5 stephan_schaefer 2002-08-21 10:47:45 UTC
The problem is that the dialog is not modal to the document window, 
but only to the database beamer. When you toggle the floating mode 
of the beamer by pressing the pin before you open the dialog 
everything is fine. This is due to the temporary floating window 
used as parent when the window is not fixed. 
As an easy workaround do not set any parent at all when constructing 
the dialog, i.e., pass NULL! This will select the famous 
DefModalDialog Parent which guarantees modality to the document 
window. Please do so for all dialogs opened from the database 
beamer. The gallery does the same, by the way.
Comment 6 Frank Schönheit 2002-08-21 11:41:35 UTC
To be honest, I do not like the idea of passing NULL. This
DefModalDialogParent is something which causes us trouble again and
again, and I do not want to introduce yet another potential problem here.

Instead, I will go up the XWindow chain in the data source browser,
until I reach a frame which returns isTop() == true. This should give
us the proper parent explicitly, instead of relying on implicit magics :).
Comment 7 Frank Schönheit 2002-10-14 13:52:18 UTC
Ocke, please care for this. We should try the approach sketched above:
go up the frame chain until we find an XTask which's isTop returns
true, and use this frame's (container or content) window as parent.
Thanks
Comment 8 Frank Schönheit 2002-12-19 14:51:27 UTC
I could not reproduce this behaviour in the latest builds, however, I
am not really happy with the problem simply vanishing.
Ocke, to be on the safe side, we should change
SbaTableQueryBrowser::implAdministrate so that it uses the top-most
window of the task it resides in (just step up the window chain). This
should prevent this bug from re-occuring. Could you please care for this?
Comment 9 ocke.janssen 2002-12-20 12:32:26 UTC
Fixed
Comment 10 ocke.janssen 2002-12-20 12:33:15 UTC
Reopen because need to reassign this to QA
Comment 11 ocke.janssen 2003-01-08 14:30:18 UTC
Fixed
Comment 12 marc.neumann 2003-01-10 11:22:08 UTC
fixed in next developer release
Comment 13 marc.neumann 2003-01-10 11:22:54 UTC
verified in next internal developer release
Comment 14 marc.neumann 2003-02-20 11:08:42 UTC
fixed in public 644 m build
see http://www.openoffice.org/dev_docs/source/644/