Issue 67452 - suppress second error message for 'not existing license file'
Summary: suppress second error message for 'not existing license file'
Status: ACCEPTED
Alias: None
Product: udk
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: All Windows, all
: P3 Trivial (vote)
Target Milestone: 4.x
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-17 12:16 UTC by b.osi.ooo
Modified: 2013-02-07 21:55 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description b.osi.ooo 2006-07-17 12:16:43 UTC 
How to reproduce:
add via extension manager:
(from OOo cvs)
qa/qatesttool/framework/basic/input/extensions/simpleLicense\MissinLic.oxt

after the message:
Adding Package(s): $FILE does not exist.
a second ulgy one comes up:
(com.sun.star.deployment.DeploymentException) { { Message = "Could 
>>> not read license text in 
>>> file:///C:/Documents%20and...

the ugly one could be supressed?
Comment 1 joachim.lingner 2006-07-17 12:25:52 UTC 
.
Comment 2 joachim.lingner 2006-07-26 16:13:42 UTC 
getLicenseText in desktop/source/deployment/registry/package/dp_package.cxx
should throw a CommandFailedException when descContent.openStream(); fails. This
indicates that the error has already been handled by the InteractionHandler (see
DialogImpl::SyncPushButton::Click() in
D:\work\cws-jl40\desktop\source\deployment\gui\dp_gui_dialog.cxx)
Comment 3 joachim.lingner 2006-07-27 10:34:45 UTC 
I guess it is better to leave the exception as it is. All error messages which
have to be displayed to the user, either in the console or through dialogs, have
be done through an interaction. So the message that comes from
SyncPushButton::Click() is an additional message and should not displayed in pro
builds.
Comment 4 joachim.lingner 2006-07-27 10:58:31 UTC 
.
Comment 5 joachim.lingner 2006-07-31 11:49:54 UTC 
.
Comment 6 joerg.skottke 2006-08-04 14:24:24 UTC 
verified by autotest
Comment 7 joachim.lingner 2006-08-04 15:23:10 UTC 
backed out again because other error messages were supressed.
Comment 8 joachim.lingner 2006-08-04 15:23:57 UTC 
.
Comment 9 joachim.lingner 2006-08-04 15:25:16 UTC 
.
Comment 10 joachim.lingner 2006-08-30 07:52:56 UTC 
.
Comment 11 Martin Hollmichel 2007-12-07 13:00:44 UTC 
set target to 3.x according to http://wiki.services.openoffice.org/wiki/Target_3x