Issue 6712 - Some dependencies fixed
Summary: Some dependencies fixed
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.0.2
Assignee: jens-heiner.rechtien
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-02 16:00 UTC by pmladek
Modified: 2003-03-06 09:25 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
This patch fixes cyclic dependencies in bootstrap (376 bytes, patch)
2002-08-02 16:01 UTC, pmladek 		no flags Details | Diff
This patch fixes some dependencies in projects (1.39 KB, patch)
2002-08-02 16:04 UTC, pmladek 		no flags Details | Diff
alternative patch for target.mk (1.23 KB, patch)
2002-08-06 19:28 UTC, hjs 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pmladek 2002-08-02 16:00:46 UTC 
I had problem to build OpenOffice.org and I fixed
some dependencies.

1. There is cyclic dependency which breaks to build
    bootstrap at once.

It was needed to run bootstrap twice to build it succesfully.
The problem was with file:
	$(SOLARVERSION)$/$(INPATH)$/inc$(UPDMINOREXT)$/minormkchanged.flg

I removed an dependency in solenv/inc/target.mk. I am not sure
but I think that this dependency is unnecessary. 

This problem was added from OOo-1.0 to OOo-1.0.1


2.  I had a problem to build some projects because of insufficient
     dependencies. 

I will attach patches wich fix both problems.
Comment 1 pmladek 2002-08-02 16:01:58 UTC 
Created attachment 2413 [details]
This patch fixes cyclic dependencies in bootstrap
Comment 2 pmladek 2002-08-02 16:04:01 UTC 
Created attachment 2414 [details]
This patch fixes some dependencies in projects
Comment 3 thorsten.martens 2002-08-06 13:18:53 UTC 
TM->HR: Can you please have alook at these patches and decide, who
should have a look at them ? Thanks !
Comment 4 jens-heiner.rechtien 2002-08-06 14:08:21 UTC 
Thorsten,

in principle:
solvenv/inc    -> hjs
external/expat -> Armin or Sander
unoil          -> jsc

First patch: looks questionable, will ask Ause (hjs).
The second patch is obviously correct. Reviewed by mh and me.

Integration pending.
I'll take this one for integration in OOO_STABLE_1

Heiner
Comment 5 hjs 2002-08-06 15:12:27 UTC 
regarding patch 1:
which version of "bootstrap.2" was used when encounting the cyclic 
dependency? does this still happen whith rev.1.12?
this dependency is needed to trigger a regeneration of "compver.mk".
Comment 6 pmladek 2002-08-06 15:21:42 UTC 
The problem exists in official OOo-1.0.1 sources.

In the file /config_office/CVS/Entries I found:
/bootstrap.2/1.12/Fri Jan 11 16:53:46 2002//TOpenOffice_1_0_1
Comment 7 hjs 2002-08-06 19:28:24 UTC 
Created attachment 2445 [details]
alternative patch for target.mk
Comment 8 jens-heiner.rechtien 2002-10-16 13:54:41 UTC 
change status
Comment 9 stx123 2002-11-18 13:07:34 UTC 
Hi Heiner/All,
what's needed to close this issue?
Thanks, Stefan.
Comment 10 Martin Hollmichel 2002-12-19 17:58:07 UTC 
this is fixed with 1.0.2
Comment 11 Martin Hollmichel 2003-03-06 09:25:38 UTC 
verified and closed.