Apache OpenOffice (AOO) Bugzilla – Issue 62422
Update of Apache Xalan-J implementation from 2.6.0 to 2.7.0
Last modified: 2006-09-25 10:22:56 UTC
The exisiting Xalan version in OpenOffice.org/StarOffice should be updated from 2.6 to 2.7. It was stated in from various developers, that the 2.7 version is in a very good condition. Furthermore, they added JAXP 1.3 and Namespace/XML 1.1 http://xml.apache.org/xalan-j/readme.html#done The downside: Apache splitted the serializer.jar from xalan.jar, therefore all classpathes have to be adapted. PS: This change has been approved by project management for StarOffice and OpenOffice.org. SUS->CMC: Hi Caloan, could you please take over this enhancement as we discussed earlier? You might join my latex CWS, but on the other hand it might be a good idea as well, to isoloate this task in a single CWS. It's up to you. One of us should write a change request/announcement about the version change and JAR change before integrating this CWS. TIA Svante
seperate workspace I think, should depend on post jaxpapi being integated to avoid getting in a tangle with that
*** Issue 64170 has been marked as a duplicate of this issue. ***
done in xalanupgrade
reopen to reassign for qaing
not sure who should be qaing this
SUS->CMC: Changed the target milestone to pp4. I will countertest this issue and we should use Jörg Sievers as QA representive BTW what have done, what have you changed? Have you added only the JARS or had you parsed all soucres for e.g. "alan.jar" and added a new "serializer.jar" to the classpathes as a new JAR has been added for Xalan7?
SUS->CMC: Any information regarding testing (see above)?
yeah, Class-Path entries in the various MANIFEST.MF have been updated to include serializer.jar so all should work out of the box. Unfortunately due to http://ooomisc.services.openoffice.org/pub/OpenOffice.org/cws/upload/readme.txt I believe the install sets may have disappeared in the interim
Some things I would likt to mention concerning our XALANUPGRADE CWS: 1. Is it possible to provide us some links to the install sets for testing? ;-) 2. Is it possible to do an 'cwsview' on the CWS to find out the changes? The main change to the earlier used Xalan 2.6 implementation is that a new serializer.jar has been splitted from the Xalan jar My test approach would be: find . -type f | xargs egrep -i "xalan.jar" With this I found in a m174 the following files: ./filter/source/config/fragments/makefile.mk: ./filter/source/xsltfilter/Manifest: ./filter/source/xsltfilter/makefile.mk: ./filter/source/xsltvalidate/makefile.mk: ./scp2/source/ooo/makefile.mk: ./scp2/source/ooo/profileitem_ooo.scp: ./xmerge/java/build.xml: ./xmerge/java/org/openoffice/xmerge/converter/xml/xslt/build.xml: 3. I realized, that the choice of the preselection of the added Xalan processor by Java property - I meant to have it earlier added long ago - , is no longer available in the sources. (find . -type f | xargs egrep -i "javax.xml.transform.TransformerFactory", did not result something useful). Therefore I recommend to add a new enhancement to this CWS as well as it has exact the same test effort/approach. Concerning the implementation, I suggest to use a generic preseclection by Java property in "filter/source/xsltfilter/XSLTransformer.java" with 'javax.xml.transform.TransformerFactory=org.apache.xalan.processor.TransformerFactoryImpl' as default. 4. What about posting the upgrade benefits as JAXP 1.3 and XML 1.1 support (see http://xml.apache.org/xalan-j/readme.html#done). It is not really a feature mail as we don't test the new features, any suggestions?
On Wed, 2006-07-19 at 14:39 +0200, Svante Schubert wrote: > Hi Caolán, > > Some things I would like to discuss with you concerning our > XALANUPGRADE CWS: > 1. Is it possible to provide us some links to the install sets > for testing? ;-) http://ooo.services.openoffice.org/pub/OpenOffice.org/cws/upload/xalanupgrade/ > 1. Is it possible to do an 'cwsview' on the CWS to find out the > changes? attached is the full workspace patch (ignoring the changed jar binaries), it's quite small > > The main change to the earlier used Xalan 2.6 implementation > is that a new serializer.jar has been splitted from the Xalan > jar > My test approach would be: > find . -type f | xargs egrep -i "xalan.jar" > > With this I found in a m174 the following files: > > ./filter/source/config/fragments/makefile.mk: > ./filter/source/xsltfilter/Manifest: > ./filter/source/xsltfilter/makefile.mk: > ./filter/source/xsltvalidate/makefile.mk: > ./scp2/source/ooo/makefile.mk: > ./scp2/source/ooo/profileitem_ooo.scp: > ./xmerge/java/build.xml: > ./xmerge/java/org/openoffice/xmerge/converter/xml/xslt/build.xml: Note the xalan jars which are users of seralizer.jar mention seralizer.jar in their Class-Path in the upsteam jars which this workspace adds, so it definitely needs to be added to scp2, but doesn't need to be added to every CLASSPATH in the source tree because if the user jar has the Class-Path entry mentioning the serializer.jar then it gets found that way. > 1. I realized, that the choice of the preselection of the added > Xalan processor by Java property - I meant to have it earlier > added long ago - , is no longer available in the sources. > (find . -type f | xargs egrep -i > "javax.xml.transform.TransformerFactory", did not result > something useful). Therefore I recommend to add a new > enhancement to this CWS as well as it has exact the same test > effort/approach. > Concerning the implementation, I suggest to use a generic > preseclection by Java property in > "filter/source/xsltfilter/XSLTransformer.java" with > 'javax.xml.transform.TransformerFactory=org.apache.xalan.processor.TransformerFactoryImpl' as default. Now, I'm afraid that with fedora's move to gcc 4, it's not possible anymore for me to create any workspaces which are able to pass automated Hamburg QA, so I can't actually build any QA-suitable workspaces. So I suggest you take ownership of the workspace, as you can create modern workspaces which are qa-able.
Created attachment 37982 [details] full workspace
SUS->JSI: Could you please verifiy this issue? The patch looks sufficient, but I havn't installed myself the cws office patch to review it, in a running Office.
JSI -> CMC/SUS: Please write an Feature Announcement (yes, it is an enhancement but we all know that it is not unimportant to know for XSLT developers what we're doing). JSI->CMC: It would be great next time to get also second platform installation set to test. We all know that there are many differences between e.g. Win32 and Unix/UNIX :-)
cmc->jsi: yeah, I know. But there is a fundamental problem :-), we don't have the windows development tools.
Going to take it over, Caolan! Thanks for your help so far. Just started to create local environment for this CWS here in Hamburg. Tomorrow we should have install sets for Windows and Linux.. Cheers, Svante
Added the new and exchanged JARS to the StarOffice patch as well. Doing this by changing macro of the file_ooo.scp of the scp2 module from STD_JAR_FILE to STD_JAR_FILE_PATCH.
verified in CWS; testcase in progress; will br attached to this issue asap.
Created attachment 38217 [details] XSLT stylesheet to get the vendor info from Xalan
Created attachment 38231 [details] first.bas test result
Created attachment 38232 [details] topten.bas test result
Created attachment 38233 [details] Writer Update test result
Created attachment 38234 [details] ODF Graphics test result
Created attachment 38235 [details] DocBook (XSLT filter) test result
Created attachment 38236 [details] Spreadsheet Import test result
Created attachment 38237 [details] Writer XML import test result
Created attachment 38238 [details] Test Case Specification for detecting the Xalan used from OOo
Created attachment 39351 [details] FIX: Type in testvase: 1 "1.0" in changed to "1"
Verified and fixed testcase. OK in OOD680m4