Issue 6135 - setup2/source/custom/reg4msdoc/register.cxx does not contain a final end of line
Summary: setup2/source/custom/reg4msdoc/register.cxx does not contain a final end of line
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Unknown
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-06-26 11:50 UTC by chris
Modified: 2002-06-28 17:58 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch to add end of line to register.cxx (440 bytes, patch)
2002-06-26 11:51 UTC, chris 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description chris 2002-06-26 11:50:07 UTC 
On the OOO_STABLE_1 branch at least, this file does not contain a final end of
line.  The problem with this is, it is impossible to create a diff that can be
applied using patch.

$ cvs diff -r OpenOffice_1_0 register.cxx > register.patch
$ patch < register.patch
patching file register.cxx
Hunk #6 FAILED at 1433.
1 out of 6 hunks FAILED -- saving rejects to file register.cxx.rej

Adding a newline on the end of the file makes it work.  Please could you commit
this patch in CVS?  I've cced to mh because he was the last to check this file in:

 *  $RCSfile: register.cxx,v $
 *  $Revision: 1.8.2.1 $
 *  last change: $Author: mh $ $Date: 2002/05/31 10:05:13 $

Thanks,
Chris Halls
Debian packaging team
Comment 1 chris 2002-06-26 11:51:00 UTC 
Created attachment 2083 [details]
Patch to add end of line to register.cxx
Comment 2 Martin Hollmichel 2002-06-26 12:43:28 UTC 
now in OOO_STABLE_1
Comment 3 chris 2002-06-28 17:58:09 UTC 
Thanks very much, Martin!  I appreciate the quick response.  

We can create good patches now from this file, so I'm marking this as
closed since there is no release involved, and to reduce QA's workload.