Issue 53237 - Assertion and Crash: ImpPageListWatcher::GetSdPage(PK_NOTES):
Summary: Assertion and Crash: ImpPageListWatcher::GetSdPage(PK_NOTES):
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: ui (show other issues)
Version: 680m118
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0.1
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-12 09:40 UTC by wolframgarten
Modified: 2010-10-23 15:35 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Test document with notes view in master page mode (9.13 KB, application/vnd.sun.xml.impress)
2005-08-12 10:58 UTC, groucho266 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description wolframgarten 2005-08-12 09:40:14 UTC 
I open a presentation, drag and drop several slides in the sorter, switch to
normal view, outline, notes and this comes up:

Debug Output
---------------------------
Error: ImpPageListWatcher::GetSdPage(PK_NOTES): access out of range
From File O:\SRC680\src\sd\source\core\PageListWatcher.cxx at Line 153
Abort ? (Yes=abort / No=ignore / Cancel=core dump)
---------------------------
Yes   No   Cancel  --------------------------- 
Pressing no results in a crash.
Comment 1 clippka 2005-08-12 10:39:20 UTC 
.
Comment 2 groucho266 2005-08-12 10:58:41 UTC 
Created attachment 28686 [details]
Test document with notes view in master page mode
Comment 3 groucho266 2005-08-12 12:00:53 UTC 
With the attached document this crash can be reprodoced like this:
1. Load the document.
2. Switch to slide 3.
3. Switch to the outline view and then to the notes view.
Comment 4 groucho266 2005-08-12 12:20:42 UTC 
The reason for the crash is the following: in the stored document the master
page mode is set for the notes view.  Switching from the outline view to the
notes view bypasses the code that resets the page mode of the notes view back to
the default (regular slides).  For some not yet known reason the page number of
the current slide set in the slide sorter bar is used to set the current page in
the notes view.  When this number is higher than the number of notes master
pages the crash occurs.

For the fix we should do the following:
1. Add a guard to DrawViewShell::SwitchPage() that catches page numbers of not
existing pages.
2. Fix the code in ViewTabBar so that when the user switches to the notes view
the edit mode is established.
3. Think about not storing the edit mode of any but the currently active view.
Comment 5 groucho266 2005-08-12 14:02:54 UTC 
Fixed by taking care of points 1 and 2 mentioned above.

Affected files:
/sd/source/ui/view/ViewTabBar.cxx    rev. 1.6.180.1
/sd/source/ui/view/drviews1.cxx    rev. 1.57.96.1
Comment 6 groucho266 2005-08-12 14:03:52 UTC 
Fixed.
Comment 7 groucho266 2005-08-12 14:48:50 UTC 
Trying to set this issue to fixed a third time.
Comment 8 clippka 2005-09-05 16:30:43 UTC 
verified in cws, back to qa

re-open issue and reassign to wg@openoffice.org
Comment 9 clippka 2005-09-05 16:30:48 UTC 
reassign to wg@openoffice.org
Comment 10 clippka 2005-09-05 16:30:52 UTC 
reset resolution to FIXED
Comment 11 wolframgarten 2005-09-06 08:59:04 UTC 
Verified in CWS.
Comment 12 wolframgarten 2005-11-15 13:00:53 UTC 
Tested in m140. CLosed.
Comment 13 tfulaporis 2010-10-23 15:35:11 UTC 
Created attachment 72560