Issue 49730 - position of all drawing objects in master documents (OpenOffice.org file format) are wrong
Summary: position of all drawing objects in master documents (OpenOffice.org file form...
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: open-import (show other issues)
Version: 680m105
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
URL:
Keywords:
: 40444 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-05-23 14:16 UTC by Oliver-Rainer Wittmann
Modified: 2013-08-07 14:41 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Oliver-Rainer Wittmann 2005-05-23 14:16:02 UTC 
Load the master document, attached to issue 40444. This is a master document in
OpenOffice.org file format.
--> Position of all drawing objects are wrong.

This defect occurs in all master documents in OpenOffice.org file format.

Broken in SRC680m96 by fix for issue 47455.
Comment 1 Oliver-Rainer Wittmann 2005-05-23 14:18:00 UTC 
accepted - fix in progress.
Comment 2 Oliver-Rainer Wittmann 2005-05-23 15:19:46 UTC 
fix available and reviewed by HBRINKM - see following 'cvs diff' output:

<cvs diff output>
RCS file: /cvs/sw/sw/source/core/doc/doclay.cxx,v
retrieving revision 1.35
diff -w -u -r1.35 doclay.cxx
--- doclay.cxx  20 Apr 2005 12:16:49 -0000      1.35
+++ doclay.cxx  23 May 2005 14:03:32 -0000
@@ -676,9 +676,12 @@
         // --> OD 2004-11-22 #i35635#
         pContact->MoveObjToVisibleLayer( pContact->GetMaster() );
         // <--
-        // --> OD 2005-04-15 #i47455# - notify draw frame format
-        // that position attributes are already set, because they are copied
-        if ( pDest->ISA(SwDrawFrmFmt) )
+        // --> OD 2005-05-23 #i40444# - notify draw frame format
+        // that position attributes are already set, if the position
attributes+        // are already set at the source draw frame format.
+        if ( pDest->ISA(SwDrawFrmFmt) &&
+             rSource.ISA(SwDrawFrmFmt) &&
+             static_cast<const SwDrawFrmFmt&>(rSource).IsPosAttrSet() )
         {
             static_cast<SwDrawFrmFmt*>(pDest)->PosAttrSet();
         }
</cvs diff output>

fix tested by ES in internal build.
Comment 3 Oliver-Rainer Wittmann 2005-05-23 15:22:31 UTC 
OD->ES: Please check fix in coming master build, Thx.

re-open issue and reassign to es@openoffice.org
Comment 4 Oliver-Rainer Wittmann 2005-05-23 15:22:43 UTC 
reassign to es@openoffice.org
Comment 5 Oliver-Rainer Wittmann 2005-05-23 15:22:49 UTC 
reset resolution to FIXED
Comment 6 eric.savary 2005-05-23 15:38:51 UTC 
ES: verified with extra library.
Waiting for integration to close.
Comment 7 eric.savary 2005-05-23 15:56:07 UTC 
*** Issue 40444 has been marked as a duplicate of this issue. ***
Comment 8 eric.savary 2005-05-24 16:49:24 UTC 
Fixed in master m106