Issue 49201 - "Custom" animations: Office does not accept mouseclick to move presi on
Summary: "Custom" animations: Office does not accept mouseclick to move presi on
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: viewing (show other issues)
Version: OOo 2.0 Beta
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: christian.guenther
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-13 06:57 UTC by sputnik1
Modified: 2005-05-27 10:47 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
bugdoc (9.81 KB, application/vnd.sun.xml.impress)
2005-05-13 09:42 UTC, wolframgarten
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description sputnik1 2005-05-13 06:57:57 UTC
Working with custom animations, specifically "appear" with both mouse click and
timed appearance, fails in slide show. List items either do not appear at all or
the slides will not progress on mouse click once animations are complete. On
occasion both!

Marked P2, might be seen as P1 - this function not working is a show-stopper for
use and review.

Noticed in shipping version on SuSE 9.3 (Novell build 1.9.79), confirmed in m100
downloaded 6/5 as RPM (installed in new directories). Not had an opportunity to
test in Windows.
Comment 1 wolframgarten 2005-05-13 09:41:20 UTC
Reproducible - in a way. I will attach a bugdoc.
Comment 2 wolframgarten 2005-05-13 09:42:02 UTC
Created attachment 26091 [details]
bugdoc
Comment 3 wolframgarten 2005-05-13 09:43:27 UTC
Reassigned. Please have a look. After the effect started there seems to be a
time where office waits for its completion. If the effect is shorter then it is
already ended but Office still does not accept a mouse click.
Comment 4 wolframgarten 2005-05-13 09:44:13 UTC
Summary adapted.
Comment 5 thb 2005-05-13 10:00:25 UTC
Adapted platform (occures everywhere), adapted prio (this is only an annoyance
for appear effects).

Some aspects of this bug are duplicate to issue 45197 (the fact that a _running_
animation cannot be skipped - you can only exit the slideshow, or proceed to the
next or previous slide). 

The underlying reason why the slideshow seems dead for a short amount of time
(between 1 and 5 seconds) is the fact that the appear effect has a non-zero
duration. 
Comment 6 thb 2005-05-13 10:03:52 UTC
To validate that: change the "speed" of the appear effect in the corresponding
custom animation pane drop-down. Try the difference between "very fast" and
"very slow", and you'll notice that the time of unresponsiveness is nearly
unnoticeable for "very fast".

A quick fix would be to ignore the speed setting for appear internally, a proper
fix would disable that drop-down for these effects - its meaningless, anyway.
Comment 7 thb 2005-05-13 17:17:32 UTC
@iha: You've already fixed that, please take over.

thb/iha: Review done.
Comment 8 IngridvdM 2005-05-13 17:36:29 UTC
Fixed in CWS impress56:
sd/source/ui/animations/CustomAnimationPane.cxx,v 1.12.34.1
sd/source/ui/animations/CustomAnimationCreateDialog.cxx,v 1.5.56.2

Fixed like follows:
Newly created animation effects of type 'appear' or 'disappear' now have a very
short duration. This duration is not allowed to be modified via UI anymore as it
doesn't make sense anyhow. So the illustrated problematic case above will not
occur with newly created documents anymore. Old documents still have the
problem. We will need to wait for fix of Issue 45197 here.
Comment 9 IngridvdM 2005-05-13 18:14:11 UTC
reopen for reassign
Comment 10 IngridvdM 2005-05-13 18:16:01 UTC
->cgu: Fixed in CWS impress56.
If something is not as wanted please give the issue and CWS back to thb or cl as
I am on vacation next week. Thanks.
Comment 11 IngridvdM 2005-05-13 18:16:29 UTC
set to fixed
Comment 12 clippka 2005-05-17 09:43:56 UTC
The fix itself is ok but it only fixes the symtoms and not the root causes.
Therefore I will remove the fixes and fix the broken effects.xml which is the
real problem here
Comment 13 groucho266 2005-05-17 14:51:55 UTC
Review done.
Comment 14 clippka 2005-05-17 15:03:23 UTC
I take over to commit my fix
Comment 15 clippka 2005-05-17 15:05:32 UTC
Ok this was a regression from one of my last changes in the create custom
animation dialog. I added that after opening the first effect was selected. In
this special case of selection the duration from the preset was not set at the
combo box. So when someone just opens this dialog and clicks on ok accepting the
appear effect and the medium duration the appear effect gets a duration which is
wrong.

I fixed this that now the initial selection also triggers the setting and
optional the disabling of the speed combo box.
Comment 16 clippka 2005-05-17 16:15:50 UTC
Verified in CWS, please check

re-open issue and reassign to cgu@openoffice.org
Comment 17 clippka 2005-05-17 16:15:59 UTC
reassign to cgu@openoffice.org
Comment 18 clippka 2005-05-17 16:16:06 UTC
reset resolution to FIXED
Comment 19 christian.guenther 2005-05-19 19:13:36 UTC
Verified in cws impress56
Comment 20 christian.guenther 2005-05-27 10:47:00 UTC
Integrated in src680m105