Issue 48263 - Crash when switching between write protect and edit file
Summary: Crash when switching between write protect and edit file
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: ui (show other issues)
Version: 680m97
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-27 12:18 UTC by wolframgarten
Modified: 2005-05-10 13:47 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description wolframgarten 2005-04-27 12:18:09 UTC 
open a new impress and save it. Click on the edit file button 4 times: task pane
is empty. Now click the view button of the taskpane: Offie crashes.
Comment 1 groucho266 2005-04-27 13:27:45 UTC 
On some occasions when the document is switched from read-only to read-write
mode the ViewShellBase is replaced by another one.  
In other occasions it is not.  One of these leads to the crash because the
PaneManager is not informed that the right pane has been made visible and
therefore does not create a TaskPaneViewShell for it.
Comment 2 groucho266 2005-04-27 15:19:01 UTC 
Fixed by making PaneDockingWindow listen for VCLEVENT_WINDOW_SHOW and
VCLEVENT_WINDOW_HIDE events and calling
PaneManager::RequestWindowVisibilityChange() as a result.

In PaneManager I had to guard the ViewFrame::SetChildWindow() calls with
ViewFrame::KnowsChildWindow() so that the view frame does not complain about the
attempt to hide an unknown child window (the right pane in read-only mode is not
only hidden, it does not exist).

Affected files:
sd/source/ui/dlg/PaneDockingWindow.cxx rev. 1.9.44.1
sd/source/ui/inc/PaneDockingWindow.hxx rev. 1.6.110.1
sd/source/ui/view/PaneManager.cxx rev. 1.18.38.1
Comment 3 groucho266 2005-04-28 12:43:50 UTC 
Back to QA for verification
Comment 4 wolframgarten 2005-04-29 09:22:28 UTC 
Setting to fixed.
Comment 5 wolframgarten 2005-04-29 09:35:30 UTC 
Reassigning issue to me for testing.

re-open issue and reassign to wg@openoffice.org
Comment 6 wolframgarten 2005-04-29 09:36:38 UTC 
reassign to wg@openoffice.org
Comment 7 wolframgarten 2005-04-29 09:36:42 UTC 
reset resolution to FIXED
Comment 8 wolframgarten 2005-04-29 09:40:12 UTC 
Verified in CWS.
Comment 9 wolframgarten 2005-05-10 13:47:51 UTC 
Tested in master m102. Closed.