Issue 46907 - Showstopper: Crash when closing impress after deleting slides
Summary: Showstopper: Crash when closing impress after deleting slides
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: ui (show other issues)
Version: 680m91
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-07 09:19 UTC by wolframgarten
Modified: 2005-04-20 08:39 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description wolframgarten 2005-04-07 09:19:53 UTC 
Open a new impress, go to slide sorter view. Insert a second slide, select all,
delete, close the impress: Office crashes. This was ok in m88, broken in m89.
Comment 1 groucho266 2005-04-07 16:58:23 UTC 
Accepted.
Comment 2 groucho266 2005-04-07 18:49:10 UTC 
In SlideSorterController::DeleteSelectedPages() the guard against deleting the
last page in a document was wrong.  It looked at the page count in
SlideSorterModel.  This, however, was updated only at the end of the method.  As
a result undo actions were generated for the last slide and its note page. The
pages themselves were not deleted in this method but when the application was
closed the undo action and with them the pages where destroyed.  They were still
a member of the document and the attempt to officially delete them from the
destructor of the document lead to the crash.

Fixed the guard again (see issue 45282). Hopefully the last time.
Comment 3 groucho266 2005-04-12 13:52:57 UTC 
Back to QA for verification.

re-open issue and reassign to wg@openoffice.org
Comment 4 groucho266 2005-04-12 13:53:04 UTC 
reassign to wg@openoffice.org
Comment 5 groucho266 2005-04-12 13:53:15 UTC 
reset resolution to FIXED
Comment 6 wolframgarten 2005-04-13 08:23:11 UTC 
Verified in CWS.
Comment 7 wolframgarten 2005-04-20 08:39:52 UTC 
Tested in master m95. CLosed.