Apache OpenOffice (AOO) Bugzilla – Issue 46270
"Find All" button in Find&Replace dialog is always disabled in Draw and Impress thus should be hidden
Last modified: 2010-05-26 17:05:22 UTC
Dear All. When I click [Edit]-[Find & Replace], "Find All" button is always not activated. So I cannot search the word at the same time. I attach capture file of bug, so check it, please. Thanks :)
Created attachment 24399 [details] "Find All" is always not activated.
Reproducible.
Reassigned.
"Find All" is for highlighting all occurences of the search string in the document. This is not possible in Draw or Impress because the pages of the document are not visible at the same time in those views where the text can be edited. Therefore the button is disabled. It would be technically possible to remove the button when this feature is not supported. However, this would require a lot of work and might introduce a lot of regression. Therefore I think it is better to leave it as it is. Maybe put a remark into the help text.
Reopening.
Back to QA.
Re-setting resolution to wontfix.
Closed.
dtardon->af: Unless I have missed something important, correction of that doesn't seem to be so hard a thing. It's just a matter of hiding the 'Find All' button and moving the 'Find' button a little. There is already _a lot_ of button hiding and position correcting in the implementation of the dialog, thus I guess one more cannot hurt. Could you reconsider fixing this issue?
Created attachment 62931 [details] proposed fix
.
lets reopen to get an opinion on that
cmc->af: what do you think, given that dtardon has cooked up a patch for it
SBA: Adjusting summary. +1 from my side to hide that button for Draw and Impress as there is no resource in sight to implement that functionality OR to re-invent that dialog in large scale (i.e. have UI to ease search for line break and the like like Word has to avoid regex study is an old request (don't know the issue ID). The F&R dialog looks a little different in the apps anyway. Note that some check boxes (Whole words, Similarity search, Current selection only) behave "useless" in Draw and Impress, too. But an estimation of the effort to make those work (before hiding them "in one go") sounds feasible.
I don't think there's any objections against doing this then, right ?. Given that, how about I take care of this.
committed to sdfindall
reassign for qa
Adjusting summary to reflect what has been done (hide that button). Verified in CWS sdfindall.
closing, integrated DEV300_m79