Issue 45002 - compiler directive -tune=pentiumpro doesn't work on all systems
Summary: compiler directive -tune=pentiumpro doesn't work on all systems
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: 680m85
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: yury_t
QA Contact: issues@tools
URL:
Keywords: oooqa
Depends on:
Blocks:
 
Reported: 2005-03-14 14:42 UTC by yury_t
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
change commited to fix this issue (1.39 KB, patch)
2005-05-20 11:15 UTC, hjs 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description yury_t 2005-03-14 14:42:27 UTC 
Makefiles in solenv/inc, namely, solenv/inc/unxfbsdi.mk and
solenv/inc/unxlngi6.mk contain compiler directive -tune=pentiumpro which doesn't
work on all systems. Specifically, on freebsd 4.11 with portr gcc33 and on
slackware 10 with gcc 3.3.4, this gives error.

This micro-patch handles the situation on freebsd:

--- BuildDir/ooo_SRC680_m85_src/solenv/inc/unxfbsdi.mk.prev     Mon Feb 28
22:52:12 2005
+++ BuildDir/ooo_SRC680_m85_src/solenv/inc/unxfbsdi.mk  Sat Mar 12 23:28:18 2005
@@ -112,14 +112,14 @@
 .ENDIF

 # flags for the C++ Compiler
-CFLAGSCC= -pipe -mtune=pentiumpro
+CFLAGSCC= -pipe
 # Flags for enabling exception handling
 CFLAGSEXCEPTIONS=-fexceptions -fno-enforce-eh-specs
 # Flags for disabling exception handling
 CFLAGS_NO_EXCEPTIONS=-fno-exceptions

 # -fpermissive should be removed as soon as possible
-CFLAGSCXX= -pipe -mtune=pentiumpro
+CFLAGSCXX= -pipe
 CFLAGSCXX+= -Wno-ctor-dtor-privacy
 PICSWITCH:=-fpic
Comment 1 hjs 2005-04-14 18:06:56 UTC 
rather than disabling this optimization try somthing like

.IF "$(GCCNUMVER)">="000300040000"
CFLAGSCC+=-mtune=pentiumpro
.ELSE
CFLAGSCC+=-mcpu=pentiumpro
.ENDIF

unxlngi6.mk is meant to support gcc >= 3.4 only.
Comment 2 hjs 2005-05-04 14:16:55 UTC 
anyone still cares about this issue?
Comment 3 yury_t 2005-05-05 09:17:23 UTC 
Yes. On freebsd-4, openoffice can be compiled with 3.3.6 (gcc from ports), can 
*not* with 3.4.1 (gcc-ooo from ports, something with symbols not found in UDK).

Is it so much trouble to add the check *hjs* proposed?
Comment 4 hjs 2005-05-18 10:40:59 UTC 
the point is that i'm willing to add this check in one of my CWS bbut i have no
way to chcheck in a frebsd build at all.
if there is someone volunteering to make sure that there is no hidden (looks
easy, but who knows?) breakage for freebsd in this change i would commot this check.
Comment 5 yury_t 2005-05-18 10:54:09 UTC 
I can test this for you, as I retain freebsd-4 as a desktop here.
Just make it clear *what* I should test.
Should it be patch, or CWS checkout etc.
Comment 6 hjs 2005-05-18 11:28:32 UTC 
change done in unxfbsdi.mk rev. 1.13.128.1
Comment 7 hjs 2005-05-19 17:14:40 UTC 
please verify

re-open issue and reassign to yury_t@openoffice.org
Comment 8 hjs 2005-05-19 17:14:44 UTC 
reassign to yury_t@openoffice.org
Comment 9 hjs 2005-05-19 17:14:47 UTC 
reset resolution to FIXED
Comment 10 hjs 2005-05-20 11:13:10 UTC 
the CWS is ause028, so the branch tag would be "cws_src680_ause028".
alternatively you could fetch this file by revision with "cvs update
-r<revision> <filename>" in the according directory (it's a local change not
depending on anything else).
for convinience i'll attach a diff based on m104 (should fit all recent milestones).
Comment 11 hjs 2005-05-20 11:15:06 UTC 
Created attachment 26361 [details]
change commited to fix this issue
Comment 12 yury_t 2005-05-21 20:43:07 UTC 
This change (makefile diff) works. Thanks!
Build environment is gcc 3.3.6 on freebsd-4.11, building m103.
Comment 13 ace_dent 2008-05-16 03:30:38 UTC 
This Issue is 'Verified' and not updated in 1yr+, so Closing.
A Closed Issue is a Happy Issue (TM).

Regards,
Andrew
 
Cleaning-up and Closing old Issues as part of:
~ The Grand Bug Squash, pre v3 ~