Issue 41272 - application crashes when closing document after selecting tabs
Summary: application crashes when closing document after selecting tabs
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: 680m73
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
: 41537 42814 42862 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-01-25 11:43 UTC by Joost Andrae
Modified: 2005-02-17 12:16 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Joost Andrae 2005-01-25 11:43:49 UTC 
open a new impress document
change tabs to Outline, Notes, Handout, Slide Sorter and then back to Normal
then close the document: --> crash

JA->AF: I was able to reproduce this on SolarisSparc when using cws vcl35 and
when using src680m73 master. I could give you a call stack if you like.
Comment 1 groucho266 2005-01-25 12:41:31 UTC 
Accepted.
Comment 2 groucho266 2005-01-26 08:59:45 UTC 
I can reproduce the crash more reliably like this:
1. Create a new Impress document.
2. Switch to the Slide Sorter View.
3. Close the document.
Comment 3 groucho266 2005-01-26 16:43:04 UTC 
When switching from one view to another the PaneManager detects that such a
switch really takes place by comparing pointers of the view shells before and
after the call to PaneDescriptor::SetViewShellType().  

Under Solaris the new view shell is (can be) created at the adress of the old
one.  Pointers of the old and new shell are thus the same. The caller,
PaneManager::Implementation::UpdateConfiguration(), thinks that no switch takes
place and therefore does not update the controller.  As a result the new shell
is used with the old controller.  This eventually leads to a crash.

Fixed by having SetViewShellType() return a bool flag that indicates whether a
switch of view shells takes place.
Comment 4 groucho266 2005-02-01 14:56:12 UTC 
Reopening...
Comment 5 groucho266 2005-02-01 14:56:41 UTC 
...reassigning...
Comment 6 groucho266 2005-02-01 14:57:05 UTC 
...resolving.
Comment 7 Joost Andrae 2005-02-01 15:59:18 UTC 
JA: verified bugfix in cws impress31
Comment 8 IngridvdM 2005-02-03 13:46:48 UTC 
*** Issue 41537 has been marked as a duplicate of this issue. ***
Comment 9 groucho266 2005-02-04 10:01:55 UTC 
Affected file is sd/source/ui/view/PaneManager.cxx.  Fixed in revision 1.10.16.1.
Comment 10 groucho266 2005-02-04 10:47:27 UTC 
Reopening because the issue has been added to a second child work space
(impressbeta3).
Comment 11 groucho266 2005-02-04 10:48:39 UTC 
Back to me, so that I can apply the fix in CWS impressbeta3.
Comment 12 groucho266 2005-02-04 10:57:26 UTC 
Applied the fix to CWS impressbeta3.
Comment 13 groucho266 2005-02-04 15:26:06 UTC 
Reopening...
Comment 14 groucho266 2005-02-04 15:29:43 UTC 
...reassigning...
Comment 15 groucho266 2005-02-04 15:30:28 UTC 
...resolving.

Please verify in CWS impressbeta3.
Comment 16 rt 2005-02-04 15:37:59 UTC 
Verified.
Comment 17 rt 2005-02-04 15:38:59 UTC 
Sorry, wrong issue.
Comment 18 rt 2005-02-04 15:40:02 UTC 
'Fixed' again.
Sorry for the confusion.
Comment 19 wolframgarten 2005-02-04 16:04:50 UTC 
Verified in CWS.
Comment 20 wolframgarten 2005-02-09 12:53:49 UTC 
Tested in master. CLosed.
Comment 21 thorsten.ziehm 2005-02-17 08:51:35 UTC 
*** Issue 42862 has been marked as a duplicate of this issue. ***
Comment 22 wolframgarten 2005-02-17 12:16:36 UTC 
*** Issue 42814 has been marked as a duplicate of this issue. ***