Issue 38630 - Crash when saving and reloading doc
Summary: Crash when saving and reloading doc
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: OOo 2.0
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-08 10:52 UTC by wolframgarten
Modified: 2005-01-05 10:12 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description wolframgarten 2004-12-08 10:52:50 UTC 
Open a new impress, insert a rectangle. Save the doc, make a reload: Crash.
This is a beta showstopper.
Comment 1 groucho266 2004-12-08 11:09:12 UTC 
Accepted.
Comment 2 groucho266 2004-12-08 12:36:52 UTC 
There where calls to ViewShellBase::UpdateController() from both
ViewShell::Init() and DrawViewShell::Init().  Both are not necessary and indeed
lead to the crash.  

The UpdateController() method is not neccessary here because the setting of the
controller at the frame that is done there is done implicitly when a new
ViewShell object is created.
Comment 3 groucho266 2004-12-08 13:13:58 UTC 
Fixed as indicated above by removing calls to ViewShellBase::UpdateController()
from ViewShell::Init() and DrawViewShell::Init().  Affected files are 
sd/source/ui/view/viewshel.cxx and
sd/source/ui/view/drvwiewsa.cxx
Comment 4 groucho266 2004-12-08 14:48:40 UTC 
Reopening...
Comment 5 groucho266 2004-12-08 14:49:12 UTC 
...reassigning...
Comment 6 groucho266 2004-12-08 14:49:31 UTC 
...resolving.
Comment 7 wolframgarten 2004-12-08 15:29:04 UTC 
Reopened. Reload still crashes.
Comment 8 wolframgarten 2004-12-08 15:29:30 UTC 
Back to Af. Please have a second look.
Comment 9 groucho266 2004-12-08 15:51:02 UTC 
Strange.  Sometimes it works, sometimes it does not.
Comment 10 groucho266 2004-12-09 14:35:19 UTC 
Ah, integrating the changes made for issue 38341 seems to improve the situation.
 No crash yet.
Comment 11 stx123 2004-12-09 16:30:18 UTC 
changing component to presentation...
Comment 12 groucho266 2004-12-10 10:13:20 UTC 
Made a change to CustomAnimationPane.cxx to use the right controller after view
shells have changed.
Comment 13 groucho266 2004-12-10 14:48:39 UTC 
With the fixes of issue 38341 I can not reproduce the crash on Solaris, either.
Comment 14 groucho266 2004-12-14 16:26:35 UTC 
Reopening...
Comment 15 groucho266 2004-12-14 16:26:55 UTC 
...reassigning...
Comment 16 groucho266 2004-12-14 16:27:09 UTC 
...reopening.
Comment 17 wolframgarten 2004-12-15 12:13:45 UTC 
Verified in CWS.
Comment 18 wolframgarten 2005-01-05 10:12:32 UTC 
Tested in m68. Closed.