Issue 38126 - HTML document or Help document modified after load
Summary: HTML document or Help document modified after load
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: open-import (show other issues)
Version: 680m63
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: ---
Assignee: h.ilter
QA Contact: issues@sw
URL:
Keywords:
: 38291 (view as issue list)
Depends on:
Blocks: 37887
  Show dependency tree
 
Reported: 2004-11-30 08:54 UTC by Oliver-Rainer Wittmann
Modified: 2013-08-07 14:41 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Oliver-Rainer Wittmann 2004-11-30 08:54:27 UTC
- open a HTML document or start the Help
--> document is modified.
Comment 1 Oliver-Rainer Wittmann 2004-11-30 09:08:05 UTC
fix in progress in cws swqbugfixes10.

regression, broken by fix for issue 35836
Comment 2 Oliver-Rainer Wittmann 2004-11-30 09:24:14 UTC
fixed in cws swqbugfixes10 - changed file:
/sw/source/ui/app/docsh2.cxx, 1.69.4.1
Comment 3 pb 2004-12-02 09:10:59 UTC
*** Issue 38291 has been marked as a duplicate of this issue. ***
Comment 4 ulf.stroehler 2004-12-02 10:42:37 UTC
As agreed with OD and HI raising Prio to '1' to get this fix into beta.
Already talked to AK and TZ that this one should be fixed on *m65*.
Comment 5 ulf.stroehler 2004-12-02 11:08:13 UTC
Impact: 
=======
each time a new Help content is loaded the "File modified - Save changes?"
dialog pops up. Therefor promoted to 'P1'.
Comment 6 Oliver-Rainer Wittmann 2004-12-02 11:30:04 UTC
reopen, because this defect has to be fixed directly for SRC680m65
Comment 7 Oliver-Rainer Wittmann 2004-12-02 12:49:14 UTC
patch to fix this defect in method <SwDocShell::Notify(..)>, file
/sw/source/ui/app/docsh2.cxx, based on revision 1.69 of this file:

@@ -396,7 +396,11 @@
        }
        else if( rHint.ISA(SfxEventHint) && 
         ((SfxEventHint&) rHint).GetEventId() == SFX_EVENT_LOADFINISHED )
-        nAction = 1;
+    {
+        // --> OD 2004-11-30 #i38126# - own action id
+        nAction = 3;
+        // <--
+    }
 
        if( nAction )
        {
@@ -416,6 +420,22 @@
                case 2:
                        pDoc->GetSysFldType( RES_FILENAMEFLD )->UpdateFlds();
                        break;
+        // --> OD 2004-11-30 #i38126# - own action for event LOADFINISHED
+        // in order to avoid a modified document.
+        // Perform the same as for action id 1, but disable <SetModified>.
+        case 3:
+            {
+                const bool bResetModified = IsEnableSetModified();
+                if ( bResetModified )
+                    EnableSetModified( FALSE );
+
+                pDoc->DocInfoChgd( GetDocInfo() );
+
+                if ( bResetModified )
+                    EnableSetModified( TRUE );
+            }
+            break;
+        // <--
                }
 
                if( pWrtShell )
Comment 8 Oliver-Rainer Wittmann 2004-12-03 14:12:19 UTC
fixed on head for SRC680m65 - changed file:
/sw/source/ui/app/docsh2.cxx, 1.70

OD->HI: Please verify on master SRC680m65
Comment 9 Oliver-Rainer Wittmann 2004-12-03 14:13:37 UTC
.
Comment 10 Oliver-Rainer Wittmann 2004-12-06 13:40:53 UTC
correct dependence
Comment 11 h.ilter 2004-12-06 13:41:44 UTC
Verified on m654_8847 = ok
Comment 12 h.ilter 2004-12-06 13:42:42 UTC
.
Comment 13 Oliver-Rainer Wittmann 2004-12-06 13:43:31 UTC
correct dependenca again