Issue 37731 - Do not export LINK to environment
Summary: Do not export LINK to environment
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: configure (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: pavel
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 41026
  Show dependency tree
 
Reported: 2004-11-23 20:01 UTC by pavel
Modified: 2006-03-14 21:02 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2004-11-23 20:01:33 UTC 
Hi,

LINK command should be set by the respective environment file like
solenv/inc/unxlngi4.mk, not by LinuxIntelEnv.Set*. Please apply something like this:

--- set_soenv.in	23 lis 2004 20:09:30 +0100	1.26
+++ set_soenv.in	23 lis 2004 20:55:43 +0100	
@@ -1689,9 +1689,9 @@
 ToFile( "CC",                $CC,                "e" );
 ToFile( "CXX",               $CXX,               "e" );
 ToFile( "USE_SYSTEM_STL",    "@USE_SYSTEM_STL@", "e" );
-if ( $COM ne "MSC" ) {
-  ToFile( "LINK",			 $CC,				 "e" );
-}
+#if ( $COM ne "MSC" ) {
+#  ToFile( "LINK",			 $CC,				 "e" );
+#}
 ToFile( "ENABLE_SYMBOLS",    "@ENABLE_SYMBOLS@",    "e" );
 ToFile( "ENABLE_CRASHDUMP",  "@ENABLE_CRASHDUMP@",  "e" );
 ToFile( "ENABLE_CUPS",       "@ENABLE_CUPS@",       "e" );

Without this change, the lines LINK* in the unx*.mk are useless.
Comment 1 foskey 2004-11-23 20:20:19 UTC 
$CC is not the correct linker for gcc.  It should be g++ or $CXX.

PLease be careful when setting this up that it is tested on a machine without a
C runtime install.
Comment 2 pavel 2004-11-23 21:28:09 UTC 
set target.
Comment 3 foskey 2004-11-24 07:28:13 UTC 
Cancel my last comment it was totally backwards.  linker is gcc and runtime is
g++.  (Teach me to add comments in morning).
Comment 4 hjs 2004-11-24 11:48:36 UTC 
see discussion in #i33384# why LINK cannot be simply set to gcc.
also, IIRC, the first place to break with gcc 3.4.x is "salhelper".
Comment 5 pavel 2004-12-06 22:20:52 UTC 
But this issue is very simple: just do not hardcode LINK variable to the env
because it should be set elsewhere.

This is not about linking with gcc or g++.
Comment 6 hjs 2005-01-06 13:41:33 UTC 
i'm absolutly fine with removing LINK from OOo environment. this would also
reduce the differences between OOo and SO environment. SO just takes the macro
set in the platform makefile.
Comment 7 pavel 2005-01-09 16:33:47 UTC 
I'll remove LINK myself.
Comment 8 pavel 2005-01-09 16:38:46 UTC 
Fixed in pj16.
Comment 9 pavel 2005-01-15 15:19:22 UTC 
waratah, maho: can you please verify this?
Comment 10 maho.nakata 2005-01-15 15:38:36 UTC 
pjanik:
confirmed.
Comment 11 pavel 2005-01-16 09:03:58 UTC 
maho verified. Thanks.
Comment 12 caolanm 2005-03-07 12:25:56 UTC 
closed