Issue 35758 - visibility attribute work
Summary: visibility attribute work
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: 680m57
Hardware: Other Linux, all
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: mnicel
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 20269
  Show dependency tree
 
Reported: 2004-10-19 10:18 UTC by mmeeks
Modified: 2005-02-02 13:49 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mmeeks 2004-10-19 10:18:05 UTC 
The source needs annotating with the symbol visibility attributes to improve
performance.
Comment 1 matthias.huetsch 2004-10-21 13:13:45 UTC 
Just a little book-keeping...

Adding dependency to issue 20269 (startup performance), inheriting priority (P2)
and target (OOo 2.0) from there.

As this issue is against the 'graphics' project, it should probably be scoped to
apply to the 'svx' library as the only / primary target.

Matthias
Comment 2 matthias.huetsch 2004-11-01 20:28:25 UTC 
Hi Nicel,

I've just commited a couple of files as symbol visibility preparation:

svx/inc/svx/svxdllapi.h
  (new file; to be used as #include "svx/svxdllapi.h")
svx/util/makefile.pmk
  (new version; defining SVX_DLLIMPLEMENTATION; preparing visibility=hidden)
svx/util/makefile.mk
  (new version; cleanup to build single 'svx' library on all platforms)
svx/source/dialog/<cui>
  (multiple new versions; #undef SVX_DLLIMPLEMENTATION for 'cui' objects)

Hope that helps,
Matthias
Comment 3 mnicel 2004-11-02 02:50:49 UTC 
Hi Matthias,

Thanks. I had created these in my local workspace and also progressed with quite
a few of the headers marking up the interfaces. Once Michael come back after
vacation this week, will commit since I don't have access to commit myself.

thanks,
-Nicel.
Comment 4 mnicel 2004-11-02 03:02:31 UTC 
Infact I had put svxdllapi.h under svx/inc/ itself and included it as #include
"svxdllapi.h". Should I be changing these references to reflect the location
svx/svxdllapi.h or is it ok to have the new header to be put under svx/inc/ itself?

thanks,
-Nicel.
Comment 5 matthias.huetsch 2004-11-02 13:12:28 UTC 
Hi Nicel,

Somehow, I already feared my work could conflict with yours. Hopefully the
conflicts are still small, and I promise not to touch any of the header files
you're working on.

Regarding "svxdllapi.h", I would prefer my "svx/svxapidll.h" approach (if it
doesn't cause too much pain for you), as this is consistent between usage within
the svx module and from outside. Remember that all public headers, including the
new svxdllapi.h, are "delivered" into the <global output tree>/inc/ svx/
directory (which is not so in sw, sc, sd which don't publish any headers).

Sorry for any inconvinience that my interference might cause for you,
Matthias
Comment 6 mnicel 2004-11-03 02:55:04 UTC 
Absolutely no problem. I'll make the changes as per "svx/svxapidll.h". Good that
we got to fix this early so that the rework is minimal.
Appreciate your help.

thanks,
-Nicel.
Comment 7 mnicel 2005-01-05 03:58:46 UTC 
svx marking is completed and committed to visibility01
Comment 8 matthias.huetsch 2005-01-18 17:41:23 UTC 
Module 'svx'  has indeed been successfully marked, and smoketests on linux/x86,
solaris/sparc, and windows do successfully pass => resolving issue as fixed.
Comment 9 matthias.huetsch 2005-01-18 17:42:36 UTC 
As this is a developer issue, marking myself as verified...
Comment 10 matthias.huetsch 2005-02-02 13:49:59 UTC 
Integrated into milestone m74 => closing...