Issue 34870 - Impress crash when I delete a masterpage and close the doc.
Summary: Impress crash when I delete a masterpage and close the doc.
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: ui (show other issues)
Version: 680m52
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-01 13:36 UTC by christian.guenther
Modified: 2004-11-04 08:33 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description christian.guenther 2004-10-01 13:36:28 UTC 
- start an Impress
- change to the masterpage
- add a masterpage with the masterpage toolbar
- delete a masterpage with the masterpage toolbar
- cloase the document (or the office)
- you get a crash.
Comment 1 groucho266 2004-10-05 09:11:48 UTC 
This is an undo related problem.
Comment 2 groucho266 2004-10-06 06:31:35 UTC 
When a page is deleted via the UI then the page is removed from the document and
placed in an undo operation.  When the document is closed the undo operation
together with the page are destroyed.
But, when calling SdMasterPagesAccess::remove() to remove a master page from a
document it is not only removed but is deleted as well.  The second attempt of
the undo operation to delete the master page leads to the crash.
Comment 3 groucho266 2004-10-06 10:48:11 UTC 
Fixed by removing master pages from the document by using core methods directly.
 This removes the double deletion and the crash.
Comment 4 groucho266 2004-10-11 09:50:16 UTC 
Step 1/3 of sending issue back to QA.
Comment 5 groucho266 2004-10-11 09:50:34 UTC 
Step 2/3 of sending issue back to QA.
Comment 6 groucho266 2004-10-11 09:50:53 UTC 
Step 3/3 of sending issue back to QA.
Comment 7 wolframgarten 2004-10-11 11:41:19 UTC 
Verified in CWS.
Comment 8 wolframgarten 2004-11-04 08:33:09 UTC 
Tested in master m60. Closed.