Issue 34189 - Wrong INCLUDE path for external modules
Summary: Wrong INCLUDE path for external modules
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: OOo 2.0
Assignee: hjs
QA Contact: issues@porting
URL:
Keywords:
: 35079 (view as issue list)
Depends on:
Blocks:
 
Reported: 2004-09-15 09:42 UTC by oliver.bolte
Modified: 2004-10-07 21:56 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for tg_ext.mk (560 bytes, patch)
2004-09-21 04:29 UTC, quetschke 		no flags Details | Diff
with WRAPCMD, based on Rev 1.56 (654 bytes, patch)
2004-09-21 11:02 UTC, hjs 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description oliver.bolte 2004-09-15 09:42:13 UTC 
In solenv/inc/tg_ext.mk the regular expression seems to fail on using 4nt sed.

 setup INCLUDE variable for use by VC++
.IF "$(GUI)$(COM)"=="WNTMSC"
.IF "$(EXT_USE_STLPORT)"==""
INCLUDE!:=$(shell $(WRAPCMD) echo $(SOLARINC) | sed 's/$(EES)\$(EES)\stl//g;s/[
$(EES)\t]*-I/;/g' )
.ELSE			# "$(EXT_USE_STLPORT)"==""
INCLUDE!:=$(shell $(WRAPCMD) echo $(SOLARINC) | sed 's/[ $(EES)\t]*-I/;/g' )
.ENDIF			# "$(EXT_USE_STLPORT)"==""
.EXPORT : INCLUDE
.ENDIF			# "$(GUI)$(COM)"=="WNTMSC"
Comment 1 hjs 2004-09-15 11:35:38 UTC 
.
Comment 2 hjs 2004-09-17 17:54:13 UTC 
.
Comment 3 quetschke 2004-09-21 04:28:23 UTC 
Argh!

Now this fails again with W32-tcsh, because SOLARINC -> INCLUDE is in posix
and not dos format.

The following patch fixes that.
Comment 4 quetschke 2004-09-21 04:29:44 UTC 
Created attachment 17820 [details]
Patch for tg_ext.mk
Comment 5 hjs 2004-09-21 10:56:33 UTC 
next try. your patch looks like overwriting the "stl" removal
Comment 6 hjs 2004-09-21 11:02:26 UTC 
Created attachment 17831 [details]
with WRAPCMD, based on Rev 1.56
Comment 7 quetschke 2004-09-21 13:39:18 UTC 
> next try. your patch looks like overwriting the "stl" removal
Yes, because my fingers typed something different from what I meant.

I meant:
+INCLUDE!:=$(shell $(WRAPCMD) echo $(INCLUDE))

Just transform the INCLUDE *after* it is stripped from the /stl , but
your patch is better.
Comment 8 quetschke 2004-09-22 21:08:05 UTC 
Committed something like the patch from (id=17831) to vq02.

Please verify.
Comment 9 hjs 2004-09-28 14:02:44 UTC 
fine
Comment 10 hjs 2004-10-05 10:53:38 UTC 
.
Comment 11 quetschke 2004-10-07 21:56:05 UTC 
*** Issue 35079 has been marked as a duplicate of this issue. ***