Issue 32592 - "First paragraph" option (on frames/pictures) isn't saved if Wrap is Through
Summary: "First paragraph" option (on frames/pictures) isn't saved if Wrap is Through
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 1.1.2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-04 23:03 UTC by gieschke
Modified: 2013-08-07 14:41 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
file with "style:number-wrapped-paragraphs" manually set to "1" (6.07 KB, application/vnd.sun.xml.writer)
2004-08-04 23:19 UTC, gieschke
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description gieschke 2004-08-04 23:03:09 UTC
"First paragraph" option (on frames/pictures) isn't saved if Wrap is Through

Steps to reproduce
1. create new text document
2. insert frame
3. set "Wrap" of frame to "Through" and select "Option"/"First paragraph"
4. save file (in OOo format)
5. open file
6. check properties of frame

Expected result
1. "Option"/"First pargraph" is selected

Actual result
1. "Option"/"First pargraph" is NOT selected


Note #1
- You can also insert a picture instead of a frame.
- You can also save the file in "StarWriter 5.0" or "Word 97/2000/XP" format,
"Option"/"First pargraph" will always be NOT selected.

Note #2
1. open saved OOo file in zip program
2. open content.xml
3. you'll see something like:

   <style:style style:name="fr1" style:family="graphics"
style:parent-style-name="Frame">
   <style:properties style:wrap="run-through" style:vertical-pos="top"
style:vertical-rel="paragraph-content" style:horizontal-pos="center"
style:horizontal-rel="paragraph"/>
  </style:style>

4. insert attribute/value style:number-wrapped-paragraphs="1" to the end of 
style:properties, so you'll get:


   <style:style style:name="fr1" style:family="graphics"
style:parent-style-name="Frame">
   <style:properties style:wrap="run-through" style:vertical-pos="top"
style:vertical-rel="paragraph-content" style:horizontal-pos="center"
style:horizontal-rel="paragraph" style:number-wrapped-paragraphs="1"/>
  </style:style>

5. make sure you're modified content.xml is in OOo file
6. open OOo file
7. check properties of frame
8. you'll see "Option"/"First pargraph" selected
9. add a space somewehre to be able to save the file again
10. save the file
11. open the file again
12. you'll see "Option"/"First pargraph" again NOT selected

This shows that OOo is ABLE to LOAD the property but NOT ABLE to SAVE the propery.


Tested on:
- Windows XP Home German, OOo 1.1.2 final German
- Windows XP Home German, OOo 680m47/1.9.m47 English
Comment 1 gieschke 2004-08-04 23:04:20 UTC
Priority 2 as this is Data loss.
Comment 2 gieschke 2004-08-04 23:19:40 UTC
Created attachment 16953 [details]
file with "style:number-wrapped-paragraphs" manually set to "1"
Comment 3 michael.ruess 2004-08-05 10:21:35 UTC
"first paragraph" option is not saved when used together with "wrap through" in
frames/graphics/objects.
Comment 4 openoffice 2004-11-18 16:04:13 UTC
dvo: Fixed in CWS swqcore02; should make it into milestone m55 or so.

The problem was that the XML filter removes non-sensical combination of
attributes. Among others, it would drop the contour and first para flags for no
wrap and wrap through. This is wrong, in that first para + wrap through makes
sense, so I enabled this again.

dvo->gieschke: Nice analysis. That saved me a good bit of time. :-)
Comment 5 openoffice 2004-12-10 12:47:00 UTC
reopen for QA
Comment 6 openoffice 2004-12-10 12:47:57 UTC
dvo->mru: Please test.
Comment 7 michael.ruess 2004-12-21 13:21:50 UTC
Verified fix in CWS swqcore02.
Comment 8 michael.ruess 2004-12-21 13:22:22 UTC
Verified.
Comment 9 michael.ruess 2005-01-21 14:26:36 UTC
Checked integration in 680m71.