Apache OpenOffice (AOO) Bugzilla – Issue 32398
Repeated build in libxml2 fails
Last modified: 2004-11-29 10:45:18 UTC
Hi, repeated build in libxml2 fails: oo@oo:~/BuildDir/ooo_SRC680_m49_src/libxml2> build build -- version: 1.113 /home/oo/BuildDir/ooo_SRC680_m49_src/libxml2 ------------- cd ./unxlngi4.pro/misc/build && cat ../../../libxml2-2.5.11.patch | patch -b -p2 && touch so_patched_so_libxml2 patching file libxml2-2.5.11/config.h Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file libxml2-2.5.11/config.h.rej patching file libxml2-2.5.11/makefile.mk Reversed (or previously applied) patch detected! Assume -R? [n]
set target
Created attachment 17290 [details] Remove config_h from patch file and ADDITIONAL_FILES
So, the problem lies with config.h being declared in ADDITIONAL_FILES: Files in ADDITIONAL_FILES are touched into existence before applying the patch. After the files are patched, ADD_FILES_FLAG_FILE (so_addfiles_so_libxml2 in this case) is touched. To function in the right order, ADD_FILES_FLAG_FILE must depend on each file in ADDITIONAL_FILES. But config.h is a file that is generated by configure. There is no point in touching/patching it before configure is run, since configure overwrites the file. After configure is run, config.h will be newer than so_addfiles_so_libxml2, which triggers dmake to try to reapply the patches, which fails. haggai->lo: Please can you explain why you added config.h back in makefile.mk rev 1.4? The commit message does not explain why or reference an issue. Patch is attached that removes config.h from additional files again and fixes the issue (tested on my Linux system).
This patch also applies to SRC680_m52 and works...
I'll take over this issue so it is fixed sooner.
Fixed in pj02.
applying this patch doesn't seem to change the resulting "config.h" :-)
hjs: can be different when OS is changed.
Build on HEAD fails: make writeable... cd ./unxlngi6.pro/misc/build && cat ../../../libxml2-2.5.11.patch | patch -b -p2 && touch so_patched_so_libxml2 can't find file to patch at input line 3 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |*** misc/libxml2-2.5.11/makefile.mk Tue May 11 18:05:00 2004 |--- misc/build/libxml2-2.5.11/makefile.mk Tue May 11 18:02:59 2004 -------------------------- File to patch: Skip this patch? [y] Skipping patch. 1 out of 1 hunk ignored can't find file to patch at input line 141 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |*** misc/libxml2-2.5.11/xml2.map Tue May 11 18:05:01 2004
Created attachment 17817 [details] add back the needed config files, someone too heavy handed.
as said above, this is fixed in pj02. It is not integrated yet.
*** Issue 34419 has been marked as a duplicate of this issue. ***
verified, closing.