Issue 27138 - text paragraphs should provide FLOWS_TO and FLOWS_FROM relations
Summary: text paragraphs should provide FLOWS_TO and FLOWS_FROM relations
Status: CLOSED FIXED
Alias: None
Product: ui
Classification: Code
Component: AccessBridge (show other issues)
Version: current
Hardware: All All
: P3 Trivial with 1 vote (vote)
Target Milestone: OOo 2.0.2
Assignee: eric.savary
QA Contact: issues@ui
URL:
Keywords: accessibility
Depends on:
Blocks: 27292
  Show dependency tree
 
Reported: 2004-03-30 12:51 UTC by billhaneman
Modified: 2006-02-09 09:30 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Rev. 1.4.7 of gnome-java-bridge.jar (354.83 KB, application/octet-stream)
2006-01-16 11:06 UTC, nospam4obr
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description billhaneman 2004-03-30 12:51:57 UTC
In all Office text content, when text flows from one paragraph to another, the
AccessibleRelations FLOWS_FROM and FLOWS_TO should be provided, to explicitly
indicate the text flow.  This is required, for instance, in order to properly
handle multi-paragraph text selection.  That is :

* consider a section of text containing two or more paragraphs
* begin selection in 'paragraph a' and continue selecting text until the
selection rolls over into 'paragraph b'.
* text selection change events should be emitted from paragraph a until the end
of the paragraph is reached (thereafter, the selection region of paragraph a
remains static, see issue 22088)
* text selection events should thereafter be emitted by paragraph b as the
selection region of paragraph b changes.
* paragraph a must indicate that its content FLOWS_TO paragraph b, and paragraph
b must indicate that its content FLOWS_FROM paragraph a, otherwise the listening
client cannot reliably construct a composite selection which spans the two
paragraphs.

This is considered a serious issue for GNOME/OO.o accessibility by the
accessibility teams.



I am marking this as a DEFECT since this feature was discussed as a requirement
when the initial paragraph/text accessibility support proposals were drafted (in
2002 I think).
Comment 1 ru 2004-04-01 08:09:20 UTC
Ralf -> Oliver: Please have a look.
Comment 2 nospam4obr 2004-04-01 09:16:43 UTC
I see several problems here:

1. writer does implement FLOWS_TO/FROM only for paragraphs spanning over two
pages, none of the other text engines implement it at all.
2. the view of the UAA maintainers is that the child-order is sufficient for the
requested purpose, so the feature would have to be implemented in the bridge
3. FLOWS_FROM/TO have been added to Java 1.5, so neither the JUAB nor the gnome
java bridge make use of it yet.
4. None of the OOo/StarOffce text components implement TEXT_SELECTION_CHANGED
events yet (see #22053#)
Comment 3 billhaneman 2004-04-01 09:29:05 UTC
The customers of the interface do not agree with the UAA maintainers.  This has
all been discussed before.  Child order is NOT sufficient, particularly since
there is no clear way to indicate when child-order is incorrect!  Furthermore,
child order will NOT work when text, which otherwise flows from one paragraph to
another, is interrupted by other sorts of objects.  

Please, we NEED this feature in all text.  The JVM issue is being worked
separately and is not justification for omitting this from UAA implementation.
Comment 4 nospam4obr 2004-04-01 10:28:29 UTC
Need to map this new relations to Java 1.5.
Comment 5 nospam4obr 2004-04-01 10:32:33 UTC
I have logged #27292# to track the bridging issue. I can't do anything on the
writer implementation though.
Comment 6 openoffice 2004-10-12 16:36:21 UTC
dvo->fs: Please have a look at this. The relevant code is probably in
sw/source/core/access/accpara.?xx. Thanks
Comment 7 openoffice 2004-10-12 17:00:08 UTC
dvo->fs: Reassign.
Comment 8 andreas.martens 2004-12-03 08:40:25 UTC
Changed prio to 4
Comment 9 billhaneman 2004-12-03 13:14:46 UTC
This relation is still needed in order to provide accessibility support for
multicolumn text and text which flows around images, etc.  In general it's
needed for quality screenreader support.  Please raise the priority!  
Comment 10 Frank Schönheit 2004-12-13 13:48:21 UTC
fs->oj: could you please have a look into this? Thanks :)
Comment 11 ocke.janssen 2005-02-22 10:29:36 UTC
Back to you again :-)
Comment 12 andreas.martens 2005-03-30 13:25:05 UTC
Ok, I raise the priority again. We have to see if we're able to fix this at
least for OOo2.0.1.
Comment 13 andreas.martens 2005-05-25 13:43:13 UTC
Considering the effort, the priority, the risk and our resource planning I've to
retarget this issue to OOo 2.0.2.
Comment 14 andreas.martens 2005-06-28 16:50:01 UTC
Redistributing dvo's issues.
Comment 15 mdxonefour 2005-09-29 11:04:59 UTC
re-targeted to OOo 3.0
Comment 16 mdxonefour 2005-09-30 07:24:34 UTC
re-targeted back to OOo 2.0.2, re-targeting to OOo 3.0 was done by error
Comment 17 Oliver-Rainer Wittmann 2005-12-01 09:03:51 UTC
fix in progress in cws swqbf49
Comment 18 Oliver-Rainer Wittmann 2005-12-02 15:25:05 UTC
Details on the implementation:
Relations CONTENT_FLOWS_FROM/_TO will be provided for following paragraphs in a
Writer document:
- paragraphs inside the page header
- paragraphs inside the page footer
- paragraphs inside text frame and inside groups of linked text frames
- paragraphs inside the footnotes
- paragraphs inside the document body
Also the corresponding events CONTENT_FLOWS_FROM_RELATION_CHANGED and
CONTENT_FLOWS_TO_RELATION_CHANGED will be submitted for paragraphs in a Writer
document.
Comment 19 Oliver-Rainer Wittmann 2005-12-05 10:50:36 UTC
fixed in cws swqbf49 - changed files:
/sw/inc/accmap.hxx, 1.25.132.1
/sw/inc/viewsh.hxx, 1.47.130.1
/sw/source/core/inc/frame.hxx, 1.45.76.1
/sw/source/core/inc/ftnfrm.hxx, 1.7.106.1
/sw/source/core/inc/viewimp.hxx, 1.30.130.1
/sw/source/core/access/accmap.cxx, 1.50.102.1
/sw/source/core/access/accpara.hxx, 1.33.132.1
/sw/source/core/access/accpara.cxx, 1.62.32.1
/sw/source/core/view/viewsh.cxx, 1.62.30.2
/sw/source/core/view/viewimp.cxx, 1.27.130.1
/sw/source/core/layout/findfrm.cxx, 1.34.134.1
/sw/source/core/layout/ftnfrm.cxx, 1.28.102.1
/sw/source/core/layout/sectfrm.cxx, 1.41.102.2
/sw/source/core/layout/frmtool.cxx, 1.85.38.2
/sw/source/core/docnode/ndsect.cxx, 1.22.32.2
/sw/source/core/docnode/ndtbl.cxx, 1.30.64.3
/sw/source/core/docnode/node.cxx, 1.25.38.3
/sw/source/core/text/frmform.cxx, 1.61.40.1

Minor re-factoring of code:
/sw/source/core/access/acccontext.hxx, 1.35.132.1
/sw/source/core/access/accframe.hxx, 1.15.132.1
/sw/source/core/access/accframe.cxx, 1.21.132.1

Additional remove <#ifdef ACCESSIBLE_LAYOUT>:
/sw/inc/fesh.hxx, 1.52.128.1
/sw/source/core/inc/rootfrm.hxx, 1.17.132.1
/sw/source/core/layout/fly.cxx, 1.71.62.1
/sw/source/core/layout/layact.cxx, 1.54.74.1
/sw/source/core/layout/newfrm.cxx, 1.21.130.1
/sw/source/core/crsr/crsrsh.cxx, 1.56.38.1
/sw/source/core/frmedt/feshview.cxx, 1.42.100.1
/sw/source/core/txtnode/ndtxt.cxx, 1.56.12.1
/sw/source/ui/inc/edtwin.hxx, 1.21.130.1
/sw/source/ui/docvw/edtwin.cxx, 1.124.22.1
Comment 20 Oliver-Rainer Wittmann 2005-12-23 08:41:17 UTC
OD->OBR: Please check this issue in internal installation set of cws swqbf49. Thx.

re-open issue and reassign to obr@openoffice.org
Comment 21 Oliver-Rainer Wittmann 2005-12-23 08:41:25 UTC
reassign to obr@openoffice.org
Comment 22 Oliver-Rainer Wittmann 2005-12-23 08:42:03 UTC
reset resolution to FIXED
Comment 23 Oliver-Rainer Wittmann 2006-01-06 13:05:12 UTC
reopen, because fix also needed in EditEngine and TextEngine
Comment 24 Oliver-Rainer Wittmann 2006-01-06 13:06:25 UTC
taking over again for fix in EditEngine.
TBE will fix the TextEngine.
Comment 25 Oliver-Rainer Wittmann 2006-01-09 16:09:09 UTC
Implementation detail for EditEngine:
Because of internal issue 103483 I will not implement the submit of the events
CONTENT_FLOWS_FROM_RELATION_CHANGED and
CONTENT_FLOWS_TO_RELATION_CHANGED - this will be done in a follow-up issue
Comment 26 thomas.benisch 2006-01-09 16:30:28 UTC
TBE: implemented AccessibleRelationTypes CONTENT_FLOWS_FROM and 
CONTENT_FLOWS_TO for TextEngine.
Comment 27 Oliver-Rainer Wittmann 2006-01-11 12:33:53 UTC
implemented relations CONTENT_FLOWS_FROM and CONTENT_FLOWS_TO in EditEngine -
changed files:
/svx/source/accessibility/AccessibleEditableTextPara.hxx, 1.18.192.1
/svx/source/accessibility/AccessibleEditableTextPara.cxx, 1.43.192.1
/svx/source/accessibility/AccessibleParaManager.cxx, 1.10.192.1
Comment 28 Oliver-Rainer Wittmann 2006-01-11 12:36:03 UTC
OD->OBR: Please check this issue.

re-open issue and reassign to obr@openoffice.org
Comment 29 Oliver-Rainer Wittmann 2006-01-11 12:36:08 UTC
reassign to obr@openoffice.org
Comment 30 Oliver-Rainer Wittmann 2006-01-11 12:36:12 UTC
reset resolution to FIXED
Comment 31 nospam4obr 2006-01-16 10:37:19 UTC
obr @ es: FLOWS_TO / FLOWS_FROM relations can be verified using at-poke utility,
even though I don't see any improvements for multi-paragraph selection in
gnopernicus.

One needs release 1.4.7 of the gnome-java-bridge.jar in /usr/share/jars, which I
will attach to this issue.

re-open issue and reassign to es@openoffice.org
Comment 32 nospam4obr 2006-01-16 10:42:56 UTC
reassign to es@openoffice.org
Comment 33 nospam4obr 2006-01-16 10:43:19 UTC
reset resolution to FIXED
Comment 34 nospam4obr 2006-01-16 11:06:57 UTC
Created attachment 33266 [details]
Rev. 1.4.7 of gnome-java-bridge.jar
Comment 35 eric.savary 2006-01-25 13:24:55 UTC
Verified in cws swqbf49
Comment 36 eric.savary 2006-02-09 09:30:52 UTC
Ok in src680m156