Issue 2100 - Sablot makefile has wrong depth (too many ../'s)
Summary: Sablot makefile has wrong depth (too many ../'s)
Status: CLOSED NOT_AN_OOO_ISSUE
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: 641
Hardware: SGI IRIX
: P3 Trivial (vote)
Target Milestone: next build
Assignee: sander_traveling
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-11-02 02:23 UTC by nickb
Modified: 2002-03-22 17:45 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
sablot/Sablot-0.52.patch - correct the depth (380 bytes, patch)
2001-11-02 02:24 UTC, nickb 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description nickb 2001-11-02 02:23:46 UTC 
The patch file for Sablot produces a makefile which looks one level to far up the
tree.
Comment 1 nickb 2001-11-02 02:24:47 UTC 
Created attachment 657 [details]
sablot/Sablot-0.52.patch - correct the depth
Comment 2 sander_traveling 2001-11-12 20:27:39 UTC 
fixed in OO641B together with adding support for IRIX.
Comment 3 mrauch-openoffice 2001-11-19 16:03:02 UTC 
This patch breaks at least NetBSD and Linux. 
Nick, can you please verify that this patch is really needed on IRIX. 
(The depth seems to be highly platform-independent.)

Thank you.
Comment 4 nickb 2001-11-20 00:04:34 UTC 
It looks like we don't get one of the subdirectorys (misc). 
Which would explain why the different depth is needed. Currently,
investigating.
Comment 5 Unknown 2001-11-20 01:17:16 UTC 
As far as I know the patch checked in for this issue is correct.
Here is my reasoning for this statement.

When performing a dmake from the sablot/ directory, the makefile will 
include the makefile "solenv/inc/tg_ext.mk" to handle the copying and 
untaring of download/Sablot-0.52.tar.gz.

In solenv/inc/tg_ext.mk: line 118
- In the rule to untar this tarball, it will change to $(PACKAGE_DIR) 
before untaring.
- $(PACKAGE_DIR) is defined on line 77 of tg_ext.mk to be "build/
$(ROUT)"
- $(ROUT) is defined to be $(OUTPATH).<ext> between lines 561 and 595 
of tg_ext.mk, and $(OUTPATH).<ext> is dependant on your OS.
- So the tarball MUST be extracted into "sablot/build/
$(OUTPATH).<ext>".
- Looking through the contents of the tarball (in IRIX, winzip & 
winrar under NT, and in LINUX), it will be extracted in to the Sablot-
0.52 directory.
- So there is no way that i can see, the contents will be untared 
into "unxlngppc.pro/misc/build/Sablot-
0.52/Sablot/engine/makefile.mk", as in this case "unxlngppc.pro" MUST 
come AFTER "build/" according to the $(PACKAGE_DIR) macro, unless 
that macro itself has been modified, any other macro PACKAGE_DIR 
uses, or tg_ext.mk has been modified.
- None of these macro's even has a "misc" directory anywhere, so I'm 
curious as to how that came about anyhow...
Comment 6 mrauch-openoffice 2001-11-20 11:41:57 UTC 
OK, George's explanation triggers a suspicion:
Which cvs revision of solenv/inc/tg_ext.mk do you have?
I mean, is it the newest one?
IIRC there was a change where external programs will get build between
638 and 641, and your expansion of the macros describes the old way.
Comment 7 nickb 2001-11-20 22:45:47 UTC 
grep tg_ext.mk CVS/Entries gives...
tg_ext.mk/1.15/Thu Sep 20 19:53:17 2001/TOO641B

Currently having trouble accessing anoncvs.openoffice.org, will update 
when its back.
Comment 8 nickb 2001-11-21 00:34:16 UTC 
Have just updated tg_ext.mk to 1.15.2.1 and this has fixed the problem.
Comment 9 stx123 2002-03-22 17:45:06 UTC 
all platforms are happy?
Otherwise reopen, please.