Issue 15344 - Last checkin to setup2/source/service/interface.cxx broke W32
Summary: Last checkin to setup2/source/service/interface.cxx broke W32
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: dirk.voelzke
QA Contact: issues@installation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-05 23:04 UTC by quetschke
Modified: 2003-09-08 16:53 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
batckout of the setup2 bsd patches. (2.83 KB, patch)
2003-06-06 13:32 UTC, foskey
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2003-06-05 23:04:05 UTC
The last checkin to setup2/source/service/interface.cxx broke the
W32 build for cws_srx644_ooo11beta2:
(.NET build)

------------------------------
Making: ../../wntmsci8.pro/slo/interface.obj
guw.pl /cygdrive/c/PROGRA~1/MICROS~1.NET/Vc7/bin/cl.exe -Zm500 -wd4290 -wd4786
-wd4800 -c -nologo -Gs -Gy  -I.  -I. -I../inc -I../../inc -I../../WIN/inc
-I../../wntmsci8.pro/inc -I.
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc/stl
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc/external
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solenv/wntmsci8/inc
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solenv/inc
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/res
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc/stl
-I/cygdrive/c/j2sdk1.4.1_02/include/win32 -I/cygdrive/c/j2sdk1.4.1_02/include
-I'/cygdrive/C/Programme/Microsoft SDK/include'
-I/cygdrive/c/PROGRA~1/MICROS~1.NET/Vc7/include     -I. -I../../res -I. -Zi
-Fd../../wntmsci8.pro/misc\_ooo_st_service.PDB -Ob1 -Ox -Gd  -GX   -DWNT -DWNT
-DNT351 -DMSC -DM1300 -DINTEL -D_USE_NAMESPACE -D_X86_=1  -DFULL_DESK
-DSTLPORT_VERSION=400 -DWINVER=0x400 -D_WIN32_IE=0x400 -D_MT -DCPPU_ENV=msci
-DSUPD=644 -DBUILD=8600 -DPRODUCT -DNDEBUG -DPRODUCT_FULL -DOSL_DEBUG_LEVEL=0
-DOPTIMIZE -DEXCEPTIONS_ON -DCUI -DSOLAR_JAVA -DSRX644  -DSHAREDLIB -D_DLL_
-DWIN32 -D_MT -D_DLL -DWIN32 -D_MT -D_DLL -DMULTITHREAD  -W3
-Fo../../wntmsci8.pro/slo/interface.obj
/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/setup2/source/service/interface.cxx 
guw.pl /cygdrive/c/PROGRA~1/MICROS~1.NET/Vc7/bin/cl.exe @/tmp/mk610cb4b8.5
Command: /cygdrive/c/PROGRA~1/MICROS~1.NET/Vc7/bin/cl.exe
cl : Befehlszeile warning D4029 : Die Optimierung ist im Standardcompiler
nicht verfÂgbar.
interface.cxx
d:\v1\cws_srx644_ooo11beta2cyg\setup2\source\service\interface.cxx(243) : error
C2065: 'OSType_UNIX_FREEBSD' : nichtdeklarierter Bezeichner
d:\v1\cws_srx644_ooo11beta2cyg\setup2\source\service\interface.cxx(583) : error
C2051: case-Ausdruck ist keine Konstante
d:\v1\cws_srx644_ooo11beta2cyg\setup2\source\service\interface.cxx(606) : error
C2051: case-Ausdruck ist keine Konstante
dmake:  Error code 2, while making '../../wntmsci8.pro/slo/interface.obj'
echo: No match.

ERROR: Error 65280 occurred while making
/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/setup2/source/service
dmake:  Error code 1, while making 'build_all'
echo: No match.

--------------------------------------------------
Comment 1 quetschke 2003-06-05 23:05:51 UTC
set target
Comment 2 quetschke 2003-06-05 23:26:12 UTC
"else if( eType == OSType_UNIX_LINUX )"

in line 129 is wrong, that should be 

   OSType_UNIX_FREEBSD

(propably)
Comment 3 pavel 2003-06-06 07:37:59 UTC
Sander,

Martin removed FreeBSD part from api/offapi/com/sun/star/setup/OSType.idl
with nice comment:

06/04/2003 08:56 mh api/ offapi/ com/ sun/ star/ setup/ OSType.idl
1.5.106.2 cws_srx644_ooo11beta2  6/5  FreeBSD patch rejected once more

(see the diff for that comment...).

So now we do not have OSType_UNIX_FREEBSD. But we use it in

pavel@pavel:~/Tmp/ooo_11beta2_src/setup2> grep -rl OSType_UNIX_FREEBSD *
source/compiler/decltor.cxx
source/service/interface.cxx
Comment 4 quetschke 2003-06-06 08:56:01 UTC
Yep, as Pavel said, it still breaks:
------------------------------
Making: ../../wntmsci8.pro/slo/interface.obj
guw.pl /cygdrive/c/PROGRA~1/MICROS~1.NET/Vc7/bin/cl.exe -Zm500 -wd4290
-wd4786 -wd4800 -c -nologo -Gs -Gy  -I.  -I. -I../inc -I../../inc
-I../../WIN/inc -I../../wntmsci8.pro/inc -I.
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc/stl
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc/external
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solenv/wntmsci8/inc
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solenv/inc
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/res
-I/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/solver/644/wntmsci8.pro/inc/stl
-I/cygdrive/c/j2sdk1.4.1_02/include/win32
-I/cygdrive/c/j2sdk1.4.1_02/include -I'/cygdrive/C/Programme/Microsoft
SDK/include' -I/cygdrive/c/PROGRA~1/MICROS~1.NET/Vc7/include     -I.
-I../../res -I. -Zi -Fd../../wntmsci8.pro/misc\_ooo_st_service.PDB
-Ob1 -Ox -Gd  -GX   -DWNT -DWNT -DNT351 -DMSC -DM1300 -DINTEL
-D_USE_NAMESPACE -D_X86_=1  -DFULL_DESK -DSTLPORT_VERSION=400
-DWINVER=0x400 -D_WIN32_IE=0x400 -D_MT -DCPPU_ENV=msci -DSUPD=644
-DBUILD=8600 -DPRODUCT -DNDEBUG -DPRODUCT_FULL -DOSL_DEBUG_LEVEL=0
-DOPTIMIZE -DEXCEPTIONS_ON -DCUI -DSOLAR_JAVA -DSRX644  -DSHAREDLIB
-D_DLL_ -DWIN32 -D_MT -D_DLL -DWIN32 -D_MT -D_DLL -DMULTITHREAD  -W3
-Fo../../wntmsci8.pro/slo/interface.obj
/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/setup2/source/service/interface.cxx

guw.pl /cygdrive/c/PROGRA~1/MICROS~1.NET/Vc7/bin/cl.exe @/tmp/mk610cb554.5
Command: /cygdrive/c/PROGRA~1/MICROS~1.NET/Vc7/bin/cl.exe
cl : Befehlszeile warning D4029 : Die Optimierung ist im
Standardcompiler nicht verfÂgbar.
interface.cxx
d:\v1\cws_srx644_ooo11beta2cyg\setup2\source\service\interface.cxx(129)
: error C2065: 'OSType_UNIX_FREEBSD' : nichtdeklarierter Bezeichner
d:\v1\cws_srx644_ooo11beta2cyg\setup2\source\service\interface.cxx(129)
: error C2593: 'Operator ==' ist mehrdeutig
       
d:\v1\cws_srx644_ooo11beta2cyg\solver\644\wntmsci8.pro\inc\tools\string.hxx(638):
kann 'BOOL operator ==(const String &,const String &)' sein
       
d:\v1\cws_srx644_ooo11beta2cyg\solver\644\wntmsci8.pro\inc\tools\string.hxx(368):
oder       'BOOL operator ==(const ByteString &,const sal_Char *)'
       
d:\v1\cws_srx644_ooo11beta2cyg\solver\644\wntmsci8.pro\inc\tools\string.hxx(366):
oder       'BOOL operator ==(const ByteString &,const ByteString &)'
        beim uebereinstimmen der Argumentliste
'(com::sun::star::setup::OSType, 'unknown-type')'
d:\v1\cws_srx644_ooo11beta2cyg\setup2\source\service\interface.cxx(583)
: error C2051: case-Ausdruck ist keine Konstante
d:\v1\cws_srx644_ooo11beta2cyg\setup2\source\service\interface.cxx(606)
: error C2051: case-Ausdruck ist keine Konstante
dmake:  Error code 2, while making '../../wntmsci8.pro/slo/interface.obj'
echo: No match.

ERROR: Error 65280 occurred while making
/cygdrive/d/v1/cws_srx644_ooo11beta2cyg/setup2/source/service
dmake:  Error code 1, while making 'build_all'
echo: No match.

--------------------------------------------------
Comment 5 sander_traveling 2003-06-06 12:28:02 UTC
Then we need to revert the dependent patches aswell and instead define
something for freebsd in some other way. 

Surely it should be possible to extend the enum? We can't possibly be
stuck with a fixed set of OS types that we cannot extend - the API
being deprecated is immaterial if it is still in use...
Comment 6 foskey 2003-06-06 13:16:01 UTC
Gcc 3.3 build crashed with fundamentally the same error.
Comment 7 foskey 2003-06-06 13:32:02 UTC
Created attachment 6704 [details]
batckout of the setup2 bsd patches.
Comment 8 sander_traveling 2003-06-06 13:44:42 UTC
please commit
Comment 9 Martin Hollmichel 2003-06-06 14:55:58 UTC
mh->dv: can you please work with jsc to come to a satisfying solution
for all (porters and api folks)
Comment 10 dirk.voelzke 2003-06-11 07:27:43 UTC
Removed folder services from build list, because nobody uses the
private service SetupService any more. The rest of the setup ( and the
scp ) project only uses the os types for windows, os2 and unix ( and
sometimes for macintosh ), so there is no need to expand the enum in
ostype.idl.
Comment 11 dirk.voelzke 2003-07-17 10:10:16 UTC
verified in srx645m9s3
Comment 12 dirk.voelzke 2003-07-17 10:10:43 UTC
.