Apache OpenOffice (AOO) Bugzilla – Issue 1361
cvs browse source - change tab default
Last modified: 2003-12-06 14:52:32 UTC
please change the default for tab expanding from 8 to 4. the openoffice.org standard tabsize is 4
reassigning to my principal account
I don't understand this issue at all. Which tabs are you referring to? Is there a URL?
Awaiting hint on this from mh.
Changing subcomponent and owner.
Heiner, can you please give a hint where to tweak this ?
Hi Jeff, The problem: Our coding guidelines mandates 4 spaces per indentation and that a tab character ^I is to be interpreted as 4 spaces. All our code is formated that way. The cvsweb.cgi scripts currently formats everything as if a tab character were 8 spaces. This means that browsing OOo source code will show wrong indentation of the code and this is very ugly. The solution: I assume that OOo uses some variant of Bill Fenners cvsweb.cgi script (it certainly looks that way). This script is usually accompanied by a configuration file called cvsweb.conf. Near the end of this file you'll find a configuration variable called $tabstop. Set it to 4: $tabstop = 4 Hope this helps Heiner
changing QA contact from bugs@ to issues@
Hi, is there any solution for the tab stop problem in sight? Heiner
I am sorry this has languished. I will speak with an engineer today about the issue, and have created an internal issue (pcn6452) to track this request. Thank you Kat
Hi, The engineer working on this reports it should be easy to accomplish and we are now working on a method to build this change into the instantiation module so it will not be lost during site upgrades. Thank you Kat
This issue will be done for the upgrade to the production site. Michael (inst-engineer) is working on automating this so he doesn't have to do it manually. He can manually do it now on staging but I'd prefer he spends the time on automating it so in the future it's built into the upgrade and doesn't get missed. Please let us know if this is going to be a problem for you if it's not on staging.
OK, no prerequisite for the "GO".
Has this been fixed in the migration?
Michael is going to work on this in the tidy up this week. He is looking at automating it for the next upgrade also. He can manually do this for the current site. I've reassigned to Kat in support to update this issue and have sent it to Michael so he can let us know as soon as it's done as it's not a difficult task.
Our instantiations engineer is working on a new inst module for the site to be ready next week that will include this enhancement. Thank you Kat
The new inst module has been pushed to the staging server (stage01.sfo.collab.net) with this change for testing.
Heiner, could you have look at the staging server (http://stage01.sfo.collab.net) and let us know, whether you're satisfied?
Hi, the "diff" function uses now 4 spaces for each tab, making the output much more readable. Thanks! Funny enough, if I view a revision of a file via the "revision" link I still get 8 spaces. More precise I get a tabstop which is expanded by my browser to 8 spaces. I understand the CVSweb interface that way: If I click on the "revision" link I get a html'ified pretty printed version of the file with expanded tabs. If I click on the "download" link I get a verbatim copy of the file (without expanding tabs, of course). At least all CVSweb server I know work that way (some do even syntax highlighting if html'ified). Could it be that OO uses an old or heavily modified version of CVSweb? My copy of cvsweb.cgi (v1.93) has a function called spacedHtmlText() which is used for the "revision", "annotate" and "diff" links. It does the mentioned expansion of tabs. Heiner
Heiner, Sorry to be so long getting back to you on this. I have communicated your comments to the engineer addresing this issue, but any further changes will be postponed until early in the new year due to our company shutdown and heavy involvement of his time in the upgrade of another site. Thank you Kat
Hi, The new inst module to address this issue (4 space tab expansion in diff) has been applied to the production server. Further changes will be worked on at earliest following the Netbeans upgrade. Thank you Kat
Reassigning all of kat's open issues to support so that I can go through them.
This is waiting in the queue for our instantiations engineer, but I need to follow up with him as he is currently absorbed in the NetBeans upgrade.
queried the engineer on this today and will post an update as soon as i get one.
a newer version of cvsweb is necessary to provide the spacedHtmlText() option. this will occur with an upgrade of sourcecast.
As agreed by Louis I will close these resolved fixed support-owned issues now. If you have trouble with that, please re-open the issue.