Issue 1361 - cvs browse source - change tab default
Summary: cvs browse source - change tab default
Status: CLOSED FIXED
Alias: None
Product: Infrastructure
Classification: Infrastructure
Component: _openoffice.org source browsing (obsolete) (show other issues)
Version: current
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Unknown
QA Contact: issues@www
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-07-31 18:32 UTC by Martin Hollmichel
Modified: 2003-12-06 14:52 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Martin Hollmichel 2001-07-31 18:32:18 UTC
please change the default for tab expanding from 8 to 4. the openoffice.org 
standard tabsize is 4
Comment 1 Unknown 2001-08-06 16:45:12 UTC
reassigning to my principal account
Comment 2 Unknown 2001-08-09 01:41:45 UTC
I don't understand this issue at all. Which tabs are you referring 
to? Is there a URL?
Comment 3 Unknown 2001-08-20 21:00:17 UTC
Awaiting hint on this from mh.
Comment 4 Unknown 2001-08-20 21:11:41 UTC
Changing subcomponent and owner.
Comment 5 Martin Hollmichel 2001-08-21 08:59:12 UTC
Heiner, can you please give a hint where to tweak this ?
Comment 6 jens-heiner.rechtien 2001-08-21 09:34:32 UTC
Hi Jeff,

The problem:

Our coding guidelines mandates 4 spaces per indentation and that a tab 
character ^I is to be interpreted as 4 spaces. All our code is 
formated that way.

The cvsweb.cgi scripts currently formats everything as if a tab 
character were 8 spaces. This means that browsing OOo source code will 
show wrong indentation of the code and this is very ugly.

The solution:

I assume that OOo uses some variant of Bill Fenners cvsweb.cgi script 
(it certainly looks that way). This script is usually accompanied by a 
configuration file called cvsweb.conf. Near the end of this file 
you'll find a configuration variable called $tabstop. Set it to 4:

$tabstop = 4

Hope this helps
  Heiner
Comment 7 Unknown 2001-11-08 23:13:55 UTC
changing QA contact from bugs@ to issues@
Comment 8 jens-heiner.rechtien 2001-11-09 13:09:37 UTC
Hi,

is there any solution for the tab stop problem in sight?

Heiner
Comment 9 Unknown 2001-11-09 18:33:54 UTC
I am sorry this has languished. I will speak with an engineer today
about the issue, and have created an internal issue (pcn6452) to track
this request.

Thank you
Kat 
Comment 10 Unknown 2001-11-12 20:18:23 UTC
Hi,

The engineer working on this reports it should be easy to accomplish
and we are now working on a method to build this change into the
instantiation module so it will not be lost during site upgrades.

Thank you
Kat
Comment 11 Unknown 2001-11-15 01:21:38 UTC
This issue will be done for the upgrade to the production site. 
Michael (inst-engineer) is working on automating this so he doesn't 
have to do it manually. He can manually do it now on staging but I'd 
prefer he spends the time on automating it so in the future it's 
built into the upgrade and doesn't get missed. Please let us know if 
this is going to be a problem for you if it's not on staging.
Comment 12 stx123 2001-11-15 12:09:02 UTC
OK, no prerequisite for the "GO".
Comment 13 stx123 2001-11-24 21:41:18 UTC
Has this been fixed in the migration?
Comment 14 Unknown 2001-11-26 06:46:46 UTC
Michael is going to work on this in the tidy up this week. He is 
looking at automating it for the next upgrade also. He can manually 
do this for the current site. I've reassigned to Kat in support to 
update this issue and have sent it to Michael so he can let us know 
as soon as it's done as it's not a difficult task.
Comment 15 Unknown 2001-11-29 22:49:16 UTC
Our instantiations engineer is working on a new inst module for the
site to be ready next week that will include this enhancement.

Thank you
Kat
Comment 16 Unknown 2001-12-07 02:05:18 UTC
The new inst module has been pushed to the staging server
(stage01.sfo.collab.net) with this change for testing.
Comment 17 stx123 2001-12-07 17:05:49 UTC
Heiner, could you have look at the staging server
(http://stage01.sfo.collab.net) and let us know, whether you're satisfied?

Comment 18 jens-heiner.rechtien 2001-12-07 19:25:51 UTC
Hi,

the "diff" function uses now 4 spaces for each tab, making the output
much more readable. Thanks!

Funny enough, if I view a revision of a file via the "revision" link I
still get 8 spaces. More precise I get a tabstop which is expanded by
my browser to 8 spaces.

I understand the CVSweb interface that way: If I click on the
"revision" link I get a html'ified pretty printed version of the file
with expanded tabs. If I click on the "download" link I get a verbatim
copy of the file (without expanding tabs, of course). At least all
CVSweb server I know work that way (some do even syntax highlighting
if html'ified).

Could it be that OO uses an old or heavily modified version of CVSweb? 

My copy of cvsweb.cgi (v1.93) has a function called spacedHtmlText()
which is used for the "revision", "annotate" and "diff" links. It does
the mentioned expansion of tabs.

Heiner











Comment 19 Unknown 2001-12-19 22:52:57 UTC
Heiner,

Sorry to be so long getting back to you on this. I have communicated
your comments to the engineer addresing this issue, but any further
changes will be postponed until early in the new year due to our
company shutdown and heavy involvement of his time in the upgrade of
another site.  

Thank you
Kat
Comment 20 Unknown 2002-01-12 00:51:37 UTC
Hi,

The new inst module to address this issue (4 space tab expansion in
diff) has been applied to the production server. Further changes will 
be worked on at earliest following the Netbeans upgrade.

Thank you
Kat
Comment 21 Unknown 2002-01-15 18:46:24 UTC
Reassigning all of kat's open issues to support so that I can go through them.
Comment 22 Unknown 2002-01-15 20:09:13 UTC
This is waiting in the queue for our instantiations engineer, but I
need to follow up with him as he is currently absorbed in the NetBeans
upgrade.
Comment 23 Unknown 2002-08-21 18:10:56 UTC
queried the engineer on this today and will post an update as soon as
i get one.
Comment 24 Unknown 2002-08-27 22:23:35 UTC
a newer version of cvsweb is necessary to provide the spacedHtmlText()
option.  this will occur with an upgrade of sourcecast.
Comment 25 michael.bemmer 2003-03-24 08:23:02 UTC
As agreed by Louis I will close these resolved fixed support-owned issues now.
If you have trouble with that, please re-open the issue.
Comment 26 michael.bemmer 2003-03-24 08:27:28 UTC
As agreed by Louis I will close these resolved fixed support-owned issues now.
If you have trouble with that, please re-open the issue.