Issue 128554 - Office 2003 SpreadsheetML: fractional seconds are silently ignored during import
Summary: Office 2003 SpreadsheetML: fractional seconds are silently ignored during import
Status: RESOLVED FIXED
Alias: None
Product: Calc
Classification: Application
Component: open-import (show other issues)
Version: 4.2.0-dev
Hardware: All All
: P5 (lowest) Minor (vote)
Target Milestone: 4.1.14
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-14 04:53 UTC by damjan
Modified: 2023-02-08 09:34 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.2.0-dev
Developer Difficulty: Easy

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description damjan 2023-01-14 04:53:53 UTC 
After fixing bug 82849, a datetime value's year, month, date, hour, minute and second are correctly imported, but any fractional seconds are silently ignored.

For example:

2023-01-14 02:03:05.67

would be imported as:

2023-01-14 02:03:05
Comment 1 damjan 2023-01-14 05:15:08 UTC 
Fixed by below commit, resolving FIXED.

commit 195282cf3d8bfaa9e1cec43b093251d9df87f4ba
Author: Damjan Jovanovic
Date:   Sat Jan 14 06:58:10 2023 +0200

When importing SpreadsheetML ss:DateTime, import the entire value, not only the
first 19 characters.

Add a test file for this bug.
Comment 2 damjan 2023-02-07 18:03:30 UTC 
Cherry-picked for AOO41X in commit ffb2f9cdf269eb2185fa8deb2236b68a23ca6fb7.
Comment 3 Matthias Seidel 2023-02-07 20:12:27 UTC 
I have conflicts when cherry-picking to AOO42X from

195282cf3d8bfaa9e1cec43b093251d9df87f4ba (trunk)

but not when I cherry-pick from

195282cf3d8bfaa9e1cec43b093251d9df87f4ba (AOO41X)

Is there a difference?
Comment 4 damjan 2023-02-08 04:34:55 UTC 
(In reply to Matthias Seidel from comment #3)
> I have conflicts when cherry-picking to AOO42X from
> 
> 195282cf3d8bfaa9e1cec43b093251d9df87f4ba (trunk)
> 
> but not when I cherry-pick from
> 
> 195282cf3d8bfaa9e1cec43b093251d9df87f4ba (AOO41X)
> 
> Is there a difference?

Yes, the document test file test/testuno/source/fvt/uno/sc/formula/TestFormulaDocs.java was changed by 7d8592c79cfa104063570593e943fed55296950b in 2022, so fixes that added test documents after that won't apply to earlier branches.

I've now cherry-picked both for AOO42X.
Comment 5 Matthias Seidel 2023-02-08 09:09:01 UTC 
Thanks!
Comment 6 Matthias Seidel 2023-02-08 09:34:59 UTC 
The same problems arise with

https://bz.apache.org/ooo/show_bug.cgi?id=81233

and

https://bz.apache.org/ooo/show_bug.cgi?id=100989