Issue 128452 - update JUnit4 from 4.10 to latest 4.12
Summary: update JUnit4 from 4.10 to latest 4.12
Status: RESOLVED FIXED
Alias: None
Product: QA
Classification: Unclassified
Component: framework (show other issues)
Version: 4.2.0-dev
Hardware: All All
: P5 (lowest) Normal
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact: Carl Marcum
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-07 22:39 UTC by Carl Marcum
Modified: 2021-05-31 20:36 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Carl Marcum 2021-05-07 22:39:38 UTC 
release notes and latest version can be found here:
https://junit.org/junit4/
Comment 1 Carl Marcum 2021-05-29 19:47:28 UTC 
Updating to junit 4.11 requires adding the hamcrest jar to the classpath also.  It seem we can use the latest Hamcrest 2.2 release.

Also testing has shown we can update junit to 4.12 without issues.
Updating to 4.13 throws an error.

[javac] <path-to>/openoffice/test/testcommon/source/org/openoffice/test/common/NamedRequest.java:161: error: reference to ParentRunner is ambiguous, both constructor ParentRunner(Class<?>) in ParentRunner and constructor ParentRunner(TestClass) in ParentRunner match
    [javac] 			super(null);
    [javac] 			^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 1 error
    [javac] 1 warning

BUILD FAILED
/home/carl/dev-git/openoffice/test/build.xml:80: Compile failed; see the compiler error output for details.
Comment 2 Carl Marcum 2021-05-30 17:33:41 UTC 
changed target version to 4.12. I will create a separate issue for moving to 4.13.x as this is more involved than libraries and dependencies. There are deeper modifications needed that will be described there.
Comment 3 Carl Marcum 2021-05-30 20:21:41 UTC 
submitted PR-130

https://github.com/apache/openoffice/pull/130
Comment 4 Carl Marcum 2021-05-30 20:23:10 UTC 
work on JUnit 4.13.2 moved to issue 128455

https://bz.apache.org/ooo/show_bug.cgi?id=128455