Issue 128416 - Failure due to moving absent file
Summary: Failure due to moving absent file
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: 4.2.0-dev
Hardware: All All
: P5 (lowest) Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-28 22:23 UTC by vorobyov.mikhail
Modified: 2020-12-10 17:31 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description vorobyov.mikhail 2020-11-28 22:23:19 UTC 
Remove code that uses a non-existent file

This code block tries to move $outfile while the previous code doesn't create
$outfile; only $outfile_sh and possibly $outfile_bat are created.

--- a/main/set_soenv.in
+++ b/main/set_soenv.in
@@ -2167,11 +2167,6 @@ if( defined($outfile_bat))
 # XI. Moving the output file to the build home directory.
 #--------------------------------------------------------
 #
-$tmp = $SRC_ROOT.$ds.$outfile;
-if (rename( $outfile, $tmp ) ne 1)
-{  `mv -f $outfile $tmp`;
-}
-
 $tmp = $SRC_ROOT.$ds.$outfile_sh;
 if (rename( $outfile_sh, $tmp ) ne 1)
 {  `mv -f $outfile_sh $tmp`;
Comment 1 Matthias Seidel 2020-12-03 09:28:59 UTC 
A "blocker" would make the program unusable or break the build process.
Can you prove that this is the case?

Anyhow, since the code is on GitHub, could you open a Pull Request there?
Comment 2 vorobyov.mikhail 2020-12-05 19:42:12 UTC 
(In reply to Matthias Seidel from comment #1)
> A "blocker" would make the program unusable or break the build process.
> Can you prove that this is the case?
> 
> Anyhow, since the code is on GitHub, could you open a Pull Request there?

I've opened a Pull Request https://github.com/apache/openoffice/pull/110.
Comment 3 Matthias Seidel 2020-12-05 19:51:22 UTC 
Thanks!
Comment 4 Matthias Seidel 2020-12-10 17:09:16 UTC 
It seems that this part was removed in trunk long ago:

https://github.com/apache/openoffice/commit/25a457539c4c9ee45d9cc1446a569f5b1532c064#diff-90c5bad7c7b6152ce7d0426fcd732255bf60d14520a136753531608f7c986757

Somehow it was never backported to AOO42X.
Comment 5 Matthias Seidel 2020-12-10 17:31:23 UTC 
Merged with:

https://github.com/apache/openoffice/pull/110

Thanks!