Issue 124421 - crash on Mac if there are problems with network connectivity
Summary: crash on Mac if there are problems with network connectivity
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 4.1.0-dev
Hardware: Mac Mac OS X, all
: P1 (highest) Critical (vote)
Target Milestone: 4.1.0
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords: crash, regression
Depends on:
Blocks:
 
Reported: 2014-03-13 22:20 UTC by Thorsten Wagner
Modified: 2014-04-04 21:23 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.1.0-beta
Developer Difficulty: ---
jsc: 4.1.0_release_blocker+


Attachments
Diagnostic Report (54.60 KB, text/plain)
2014-03-13 22:20 UTC, Thorsten Wagner
no flags Details
Screenshot of message after manual search (no network connectivity, no crash) (142.15 KB, image/png)
2014-03-21 17:11 UTC, Thorsten Wagner
no flags Details
patch to disable type_info generation for the OSX64 uno bridge (3.69 KB, patch)
2014-03-27 14:12 UTC, hdu@apache.org
jsc: review+
Details | Diff
patch to force the availability of type_info symbols for ucb exceptions (1.24 KB, patch)
2014-03-27 14:23 UTC, hdu@apache.org
jsc: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Thorsten Wagner 2014-03-13 22:20:04 UTC
Created attachment 82856 [details]
Diagnostic Report

Using the 64 bit version of OpenOffice on Mac OS X the application crashes without network connectiviy after 2 minutes.

Steps to reproduce:

(1) End OpenOffice application (no OpenOffice process running)

(2) Disconnect all networks (wireless and wired)

(3) Wait some time (I don't know exactly how long)

(4) Start OpenOffice and wait 2 minutes or do something within OpenOffice

The diagnostic report attached to this bug report has the following entry:

"terminating with unexpected exception of type com::sun::star::ucb::InteractiveNetworkGeneralException abort() called"

After reconnecting networks the problem disappears.

This behaviour has been produced with the current revison 1576748 from trunk, but appears with earlier revisions of the 64 bit version too.
Comment 1 Oliver-Rainer Wittmann 2014-03-14 08:48:39 UTC
I assume that the automatic check for updates is active and that this functionality triggers the crash as it tries to setup an HTTP connection.

@Thorsten Wagner:
Did you experience the same problem with AOO 4.0.1 or earlier versions?
Comment 2 Thorsten Wagner 2014-03-14 12:14:23 UTC
The crash occurs reproducible after 35 seconds measured from starting OpenOffice.

AOO 4.0.1 is not affected.

I tried disabling automatic updates, unfortunately without success. The problem still exists and disappears after connecting to the network again.
Comment 3 Thorsten Wagner 2014-03-14 12:32:16 UTC
Sorry, maybe my previous test was wrong: The problem disappears when disabling automatic updates now.
Comment 4 Rainer Bielefeld 2014-03-19 11:23:45 UTC
Some more precise information would help to find out whether other OS also are affected.

@Thorsten Wagner
(a) 4.0.1 still not affected or only no Update search done?
(b) Does the crash appear when you do 'Tools -> Options -> OO -> Online Update 
    -> [Search Now]'?
(b2) If yes after what time?
Comment 5 Thorsten Wagner 2014-03-20 20:41:27 UTC
(In reply to Rainer Bielefeld from comment #4)
> Some more precise information would help to find out whether other OS also
> are affected.
> 
> @Thorsten Wagner
> (a) 4.0.1 still not affected or only no Update search done?
> (b) Does the crash appear when you do 'Tools -> Options -> OO -> Online
> Update 
>     -> [Search Now]'?
> (b2) If yes after what time?

(a) AOO 4.0.1 seems to be not affected.

(b) The crash occurs about 30 seconds from start of OpenOffice without doing anything. I didn't try to originate a manual search. I will give a feedback about manual search after investigation.
Comment 6 Thorsten Wagner 2014-03-21 17:10:29 UTC
(1) With automatic updates turned on the crash occurs about 30 seconds after starting OpenOffice.

(2) Without automatic updates there is no crash, even when originating a manual search (see attached screenshot).
Comment 7 Thorsten Wagner 2014-03-21 17:11:44 UTC
Created attachment 82944 [details]
Screenshot of message after manual search (no network connectivity, no crash)
Comment 8 Oliver-Rainer Wittmann 2014-03-25 08:14:03 UTC
I got access to a Mac OS X 10.9.2 system and I was able to reproduce the described crash.

It occurs with AOO 4.1.0 Beta, but not with AOO 4.0.1
--> marking it as a regression.


I will perform a further check with a new build of recent branch AOO410.
Comment 9 Oliver-Rainer Wittmann 2014-03-25 10:03:53 UTC
(In reply to Oliver-Rainer Wittmann from comment #8)
> I got access to a Mac OS X 10.9.2 system and I was able to reproduce the
> described crash.
> 
> It occurs with AOO 4.1.0 Beta, but not with AOO 4.0.1
> --> marking it as a regression.
> 
> 
> I will perform a further check with a new build of recent branch AOO410.

The new build showed the same crash.
Comment 10 Oliver-Rainer Wittmann 2014-03-26 18:47:59 UTC
I checked this issue on Windows 7. Result: no crash.
--> crash seems to be platform-dependent
Comment 11 hdu@apache.org 2014-03-27 14:12:16 UTC
Created attachment 83008 [details]
patch to disable type_info generation for the OSX64 uno bridge

Jürgen found out that the problem only happened when the dynamic loading of the typeinfo symbol for InteractiveNetworkGeneralException failed and the uno bridge had to generate the typeinfos themselves. Disabling the generation of synthetic typeinfos and handling the consequences gracefully seems to be a better approach.
Comment 12 hdu@apache.org 2014-03-27 14:23:47 UTC
Created attachment 83009 [details]
patch to force the availability of type_info symbols for ucb exceptions

The patch before allows the OSX64 bridge to handle missing type_info symbols of UNO exceptions gracefully. This patch forces the availability of type_info symbols that are thrown by the usb module.

So the bridge-patch solves the general problem of missing type_info symbols by handling them gracefully. This patch solves the particular problem that having the  type_infos of thrown exceptions is always good. So the both patches address different aspects of the problem that caused the reported crash.
Comment 13 jsc 2014-03-27 15:03:00 UTC
grant showstopper flag because the root cause is deeper in the UNO bridge which is new for 64 bit and the clang compiler
Comment 14 jsc 2014-03-27 15:05:29 UTC
Comment on attachment 83009 [details]
patch to force the availability of type_info symbols for ucb exceptions

it can't be bad to help the compiler to force the generation of the necessary type info. And it's harmless because never called.
Comment 15 jsc 2014-03-27 15:08:26 UTC
Comment on attachment 83008 [details]
patch to disable type_info generation for the OSX64 uno bridge

looks ok so far, but we should try to find a more general fix for UNO to ensure that the rtti exception type info is always generated. And we should check if cppu::unoThrow is really necessary in this context or if it is better to throw the exception directly.
Comment 16 SVN Robot 2014-03-27 15:41:07 UTC
"hdu" committed SVN revision 1582359 into trunk:
#i124421# disable generated type_info for the OSX64 uno bridge
Comment 17 SVN Robot 2014-03-27 15:42:56 UTC
"hdu" committed SVN revision 1582360 into branches/AOO410:
#i124421# disable generated type_info for the OSX64 uno bridge
Comment 18 SVN Robot 2014-03-27 15:50:58 UTC
"hdu" committed SVN revision 1582365 into trunk:
#i124421# force the availability of type_info symbols thrown by the ucb module
Comment 19 SVN Robot 2014-03-27 15:52:40 UTC
"hdu" committed SVN revision 1582368 into branches/AOO410:
#i124421# force the availability of type_info symbols thrown by the ucb module
Comment 20 hdu@apache.org 2014-03-27 15:54:00 UTC
Fixed with the commits above on trunk and the AOO410 branch.
Comment 21 SVN Robot 2014-03-28 11:27:01 UTC
"hdu" committed SVN revision 1582709 into trunk:
#i124421# use OSL_ debug helpers instead of tools DBG_ stuff
Comment 22 SVN Robot 2014-03-28 11:31:27 UTC
"hdu" committed SVN revision 1582710 into branches/AOO410:
#i124421# use OSL_ debug helpers instead of tools DBG_ stuff
Comment 23 Steve Yin 2014-04-03 05:17:04 UTC
Verified on branch AOO410. Rev. 1583666
Comment 24 Thorsten Wagner 2014-04-04 21:23:21 UTC
Reviewed successful with trunk revision 1582709