Apache OpenOffice (AOO) Bugzilla – Issue 119097
IP clearance: remove XWorkplace helpers and their usage
Last modified: 2012-05-02 12:47:01 UTC
The xwphook.h has a license that is incompatible for a product released under the ASF umbrella. There was a similar problem in the past that was solved by relicensing it (https://issues.apache.org/ooo/show_bug.cgi?id=113474#c1). Short of that we have to remove it and its use in vcl/source/window/menu.cxx
I forgot to update the license header for this file. As in sal/osl/os2/helpers/*.h, these headers can get a license upgrade.
ALG: There are two files to be handled: vcl\inc\os2\wingdi.h vcl\inc\os2\xwphook.h
Update headers to Alv2 headers, this was spposed to be done earlier as for other sal os2 headers. Sending os2/wingdi.h Sending os2/xwphook.h Committed revision 1303401.
Wonderful, thanks Yurio. So this is fixed then.
(In reply to comment #3) > Update headers to Alv2 headers, this was spposed to be done earlier as for > other sal os2 headers. > Sending os2/wingdi.h > Sending os2/xwphook.h > Committed revision 1303401. Hi, Sorry to be picky but xwphook.h still says: "2009-06-15 published under LGPL3 with Ulrich Mller permission." If the XWorkplace helpers package is under a liberal license, there's no problem, we just remove the note, otherwise we have to ask permission to Ulrich Müller to relicence. Also, not a huge problem but since these files are not in the SGA, we should use the standard AL2 boilerplate and not the one use by Oracle (I think).
@Yuri: Please take over this issue - Thx.
I don't understand the issue, also file into sal/osl/os2/*.h have similar headers and they are ok. Or are they all wrong?
The https://svn.apache.org/repos/asf/incubator/ooo/trunk/main/sal/osl/os2/*h files look OK, but debug.c, except.c and xwphook.h are problematic because as of now they do not comply with http://www.apache.org/legal/3party.html#principles because the most restrictive license applies by default. In the past it was possible to relicense these files to be used in OOo so there is hope they can be relicensed for AOO as well. Is that so? As far as I see the files are not too critical, so plan B is to stub out async exception reporting and hilite support on OS/2.
Exception support coming from XWP is quite old and there is a far better replacement now (exceptq), and I was already planning to replace it. Hilite support requires only a data structure and two strings, I can just add the required bits to os2 headers. So go with plan B.
That's great news, thanks. So we're about to remove debug.[ch], except.[ch] and dosh.h in sal, xwphook.h in vcl and xwphook.h being included in vcl's menu.cxx. I'm afraid this will break the build on OS/2 though until the replacements are ready.
sal, vcl: remove OS/2 exception handling and menu hilite code due to incorrect licensing (code will be reworked soon). Committed revision 1305868.
Much appreciated, thanks! That issue is resolved then.
Closing resolved issue.