Issue 117414 - Invalid ODF markup saved in tables
Summary: Invalid ODF markup saved in tables
Status: CONFIRMED
Alias: None
Product: Impress
Classification: Application
Component: save-export (show other issues)
Version: version58
Hardware: PC Windows 7
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-16 22:13 UTC by chris.rae
Modified: 2017-05-20 11:08 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Sample file (details of how to create it also in description) (13.04 KB, application/vnd.oasis.opendocument.presentation)
2011-03-16 22:13 UTC, chris.rae
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description chris.rae 2011-03-16 22:13:05 UTC
Created attachment 76124 [details]
Sample file (details of how to create it also in description)

Impress saves invalid ODF markup in tables in certain circumstances.

Repro:

1. Create a new presentation in Impress
2. Insert a table (size doesn't matter)
3. Save as ODP

Unpack the file. Inside \styles.xml is:


    <table:table-template text:style-name="default">
      <table:first-row text:style-name="gray3"/>
      ...

This is invalid markup according to ODF 1.2. In the ODF 1.2 schemas,
text:style-name cannot live in table:first-row (it should be table:style-name
instead):

       <define name="table-first-row">
              <element name="table:first-row">
                     <ref name="common-table-template-attlist"/>
                     <empty/>
              </element>
       </define>

       ...

       <define name="common-table-template-attlist">
              <attribute name="table:style-name">
                     <ref name="styleNameRef"/>
              </attribute>
              <optional>
                     <attribute name="table:paragraph-style-name">
                           <ref name="styleNameRef"/>
                     </attribute>
              </optional>
       </define>


Suggested fix: Use table:style-name inside tables instead.

I have also filed this as a LibreOffice bug (https://bugs.freedesktop.org/show_bug.cgi?id=35190).
Comment 1 wolframgarten 2011-03-21 10:08:30 UTC
Reproducible. Reassigned.
Comment 2 thb 2011-10-28 14:00:20 UTC
For reference, fixed for LibreOffice via this bug: http://bugs.freedesktop.org/show_bug.cgi?id=35190
Comment 3 Oliver-Rainer Wittmann 2012-06-13 12:27:15 UTC
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.
Comment 4 zong dong jun 2012-11-05 09:08:54 UTC
confirm on Aoo3.5
Comment 5 Marcus 2017-05-20 11:08:45 UTC
Reset assigne to the default "issues@openoffice.apache.org".