Issue 117313 - xmloff: unused bPrevCharIsSpace variable
Summary: xmloff: unused bPrevCharIsSpace variable
Status: CONFIRMED
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: DEV300m101
Hardware: PC All
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 10:16 UTC by caolanm
Modified: 2013-03-11 15:01 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
remove it, keep current logic (538 bytes, patch)
2011-03-10 10:16 UTC, caolanm 		no flags Details | Diff
alternatively, possible it might have been intended to use it (565 bytes, patch)
2011-03-10 10:16 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2011-03-10 10:16:23 UTC 
Created attachment 76069 [details]
remove it, keep current logic

In XMLTextParagraphExport::exportParagraph there is a branch where a "bPrevCharIsSpace" is set but unused, while in the other branch a "bPrevCharIsSpace" is set but used.

Attached is two patches, the first to just remove the unused variable, but I guess there's a small possibility that it might have been intended to use it, i.e. patch 2
Comment 1 caolanm 2011-03-10 10:16:54 UTC 
Created attachment 76070 [details]
alternatively, possible it might have been intended to use it
Comment 2 Oliver-Rainer Wittmann 2012-06-13 12:17:02 UTC 
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.
Comment 3 Rob Weir 2013-03-11 15:01:14 UTC 
I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:  dev@openoffice.apache.org

Thanks!

-Rob