Issue 113474 - vcl/os2/inc/xwphook.h has GPLv2 license
Summary: vcl/os2/inc/xwphook.h has GPLv2 license
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: DEV300m83
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Yuri Dario
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-27 19:26 UTC by pmladek
Modified: 2017-05-20 10:30 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pmladek 2010-07-27 19:26:43 UTC 
The file vcl/os2/inc/xwphook.h seems to be under GPLv2 license:

--- cut ---
/*
 * xwphook.h:
 *      header for both xwphook.c and xwpdaemon.c. This is also
 *      included from a number of sources for XFLDR.DLL which need
 *      to interface (configure) the daemon.
 */

/*
 *      Copyright (C) 1999-2002 Ulrich M<94>ller.
 *      This program is free software; you can redistribute it and/or modify
 *      it under the terms of the GNU General Public License as published by
 *      the Free Software Foundation, in version 2 as it comes in the COPYING
 *      file of the XWorkplace main distribution.
 *      This program is distributed in the hope that it will be useful,
 *      but WITHOUT ANY WARRANTY; without even the implied warranty of
 *      MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *      GNU General Public License for more details.
 */
--- cut ---

Thus it can't be compipled together with LGPLv3 code.

It has been added on 2007/10/04, see
http://hg.services.openoffice.org/DEV300/annotate/0ac6a31246bc/vcl/os2/inc/xwphook.h

--- cut ---
INTEGRATION: CWS os2port02 (1.1.2); FILE ADDED
2007/10/04 19:45:43 ydario 1.1.2.1: Issue number: i82034
Submitted by: ydario
Reviewed by: ydario
Commit of changes for OS/2 CWS source code integration. 
--- cut --- 

It solved http://qa.openoffice.org/issues/show_bug.cgi?id=82034


The header is included only on OS/2 in vcl/source/window/menu.cxx:

--- cut ---
#ifdef OS2

#include <xwphook.h>
--- cut ---

=> the OOo build for Windows, Linux, ... should be on the safe side but...
Comment 1 Yuri Dario 2010-07-27 23:56:39 UTC 
This file already has LGPL3 permission, I already got the permission from
author, and the other files in sal3 has been already changed in 2009. This one
has not been checked in last commit.

I'll add new license in os2port07 code.
Comment 2 philipp.lohmann 2010-07-28 10:19:32 UTC 
@ydario: thanks for taking care of this
Comment 3 Yuri Dario 2011-11-08 22:44:31 UTC 
Fixed in os2port07.